Repository navigation
[CRAFTING] fix(rich-text-web): discard the typed value when pressing escape - #2458
Closed
samuelreichert wants to merge 1 commit into
Closed
samuelreichert wants to merge 1 commit into
samuelreichert wants to merge 1 commit into
Conversation
samuelreichert
force-pushed
the
test/rich-text-unit-coverage
branch
from
October 12, 2026 09:11
be0a685 to
a153c39
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samuelreichert
force-pushed
the
fix/rich-text-config-escape-draft
branch
from
October 12, 2026 12:57
ee126ac to
f747704
Compare
Contributor
Author
|
Superseded by #2495, which combines this fix with the other Rich Text fixes on top of the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
In a configuration dropdown field (for example, the table configuration), pressing Escape saved the typed value instead of discarding it.
Root cause: Escape called
clearDraft()(a state update) and thenblur()straight away.onBlurran before the update applied and committed the draft.Fix: a ref set around the Escape-triggered blur makes
onBlurskip the commit.The change was written test-first: the new regression test failed before the fix. Lint and the full package test suite pass, and there is a CHANGELOG entry under
[Unreleased].Based on
main(rebased after #2453 was merged).What should be covered while testing?
🤖 Generated with Claude Code