Repository navigation
[WC-3594] Charts: keep design preview within its parent - #2473
Conversation
dc7d9d8 to
89b207d
Compare
26b9e3f to
03edcd8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
03edcd8 to
6bfc334
Compare
This comment has been minimized.
This comment has been minimized.
6bfc334 to
cbb55a0
Compare
AI Code Review
What was reviewed
Skipped (out of scope): CI checks: could not be fetched (required approval). All editorPreview callers spread Findings
|
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
The design mode preview of the chart widgets ignored the width and height settings and always rendered at a fixed 300×232px (385px wide with legend) inside an
inline-flexwrapper. In a parent narrower than that, for example a layout grid column with a manual width, the preview spilled over neighbouring widgets.The shared
ChartPreviewnow applies width unit, width, height unit and height the same way the runtime does, and is capped at 100% of its parent, so it follows the configuration and never grows past its container. This covers the area, bar, bubble, column, heatmap, line, pie/doughnut and time series charts. Custom chart has its own preview and is not changed.Note: the recording on the ticket was made with the legacy Charts module (1.4.11,
com.mendix.widget.custom.*), which is not in this repo and is not affected by this change.Ticket: https://mendix.atlassian.net/browse/WC-3594
No XML changes, no docs PR needed. Changelog entries added to the eight affected chart widgets.
What should be covered while testing?
All checks are in Studio Pro design mode, no need to run the app.