Repository navigation
[WC-3627] remove data widgets dependencies from atlas sass variables - #2474
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
yordan-st
previously approved these changes
Oct 16, 2026
samuelreichert
previously approved these changes
Oct 16, 2026
gjulivan
force-pushed
the
data-widget/atlas-sass-detach
branch
from
November 3, 2026 13:56
b1e4b2e to
0e794e9
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
dismissed stale reviews from samuelreichert and yordan-st
via
November 3, 2026 13:58
aa40cee
gjulivan
force-pushed
the
data-widget/atlas-sass-detach
branch
2 times, most recently
from
November 3, 2026 14:00
aa40cee to
dddaeb4
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
data-widget/atlas-sass-detach
branch
from
November 3, 2026 14:03
dddaeb4 to
79294f0
Compare
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): none CI: pending: sigridci · unrelated failures: security/snyk (external scanner, no SCSS or code issues reported) Questions
Positives
|
leonardomendix
approved these changes
Nov 5, 2026
samuelreichert
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Makes the Data Widgets styling independent of Atlas Sass variables. Every Sass variable the data widgets use is now declared in the module's
variables.scsswith!default. When Atlas is present and declares the same variable, the Atlas value wins. Without Atlas, the module's own value is used.Changes:
variables.scss: added$color-primary-light,$gray-lighter,$font-color-default,$screen-mdand$screen-lg. Replaced$caption-colorwith$font-color-default. Replaced the computed$color-default-lighter(mix()) and$shadow-color(rgba($gray-primary, …)) with fixed values, so the module compiles without Atlas color functions.#{$var}). Without interpolation, the fallback was written to the CSS as the literal text$var.var(--font-color-default, $font-color-default)instead of$caption-color, which compiled to a fixed#0a1325in every theme. The pager now follows the theme's text color, which fixes unreadable pager text in dark themes.color-mix(in srgb, $brand-primary 40%, transparent). It looks the same as the previousrgba($brand-primary, 0.4)and still follows a custom brand primary color, but it also compiles when$brand-primaryis a CSS variable. With Atlas,--brand-primary-200still applies.$caption-colorno longer applies.Visible changes:
#4a4a4cin the default Atlas theme instead of#0a1325. This is the cause of the failing screenshot tests for the datagrid date, number and text filters and for Gallery. Those baselines need to be updated.rgba(231, 231, 233, 0.66)instead ofrgba(206, 208, 211, 0.66)). Apps with Atlas are not affected.What should be covered while testing?
🤖 Generated with Claude Code