Skip to content

[WC-3624] Progress circle : allow overflow - #2483

Merged
gjulivan merged 2 commits into
mainfrom
progress-circle/allow-overflow
Nov 2, 2026
Merged

gjulivan merged 2 commits into
mainfrom
progress-circle/allow-overflow

Conversation

@gjulivan

@gjulivan gjulivan commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

added configuration: Allow values above maximum.

solving : #2464

@github-actions

This comment has been minimized.

r0b1n
r0b1n previously approved these changes Oct 22, 2026
@gjulivan
gjulivan force-pushed the progress-circle/allow-overflow branch from 4b2f967 to 252b662 Compare October 29, 2026 12:20
@github-actions

This comment has been minimized.

@gjulivan
gjulivan force-pushed the progress-circle/allow-overflow branch from 7aa10bf to 9a1a724 Compare October 29, 2026 12:49
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
progress-circle-web/src/ProgressCircle.xml, typings/ProgressCircleProps.d.ts New boolean property allowValueAboveMax (default false) and its matching typings
progress-circle-web/src/util.ts calculatePercentage takes an allowValueAboveMax flag and removes floating-point noise before rounding
progress-circle-web/src/components/ProgressCircle.tsx The above-max error is suppressed when allowed. A widget-progress-circle-overflow class is added. The ring stays full because the animate call still uses the clamped percentage.
progress-circle-web/src/ProgressCircle.tsx, .editorPreview.tsx, .editorConfig.ts The flag is passed through to the runtime and the preview. The Studio Pro check is skipped when the flag is on.
progress-circle-web/src/__tests__/util.spec.ts, components/__tests__/ProgressCircle.spec.tsx New unit tests for the percentage maths and the overflow behaviour
progress-circle-web/CHANGELOG.md User-facing entry under [Unreleased]

Skipped (out of scope): none

CI: pending: Run code quality check, Plan E2E matrix, sigridci · unrelated failures: security/snyk (external scanner; the code and license Snyk checks pass)


Positives

  • The change is backward compatible: the new property defaults to false, so existing apps behave as before.
  • The edge cases are tested: empty range, max below min, values below min, and rounding.
  • The changelog entry describes behavior for app developers and mentions the new CSS class.

@gjulivan
gjulivan merged commit 7943a33 into main Nov 2, 2026
13 of 14 checks passed
@gjulivan
gjulivan deleted the progress-circle/allow-overflow branch November 2, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants