Skip to content

fix(file-uploader): refresh filenames after external rename - #2496

Open
avapk wants to merge 1 commit into
mendix:mainfrom
avasis-ag:fix/file-uploader-external-rename
Open

avapk wants to merge 1 commit into
mendix:mainfrom
avasis-ag:fix/file-uploader-external-rename

Conversation

@avapk

@avapk avapk commented Oct 28, 2026

Copy link
Copy Markdown

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

Renaming a file through a custom dialog leaves its old name displayed in File Uploader.

File entries now subscribe to changes to the file’s Name attribute and refresh the displayed name. Subscriptions are cleaned up when entries are removed or unmounted. The filename updates even when Mendix reuses the same object instance.

Includes regression tests for existing and newly uploaded files, and a changelog entry.

Validation:

  • All 139 unit tests pass using source mappings for shared workspace packages.
  • TypeScript, formatting, and widget build pass.
  • Lint could not run because the local dependencies lack @eslint-react/eslint-plugin.
  • Verification in a running Mendix app remains outstanding.

What should be covered while testing?

  1. Configure File Uploader with a custom action that opens a rename dialog.
  2. Upload a file, open the dialog, change its Name, and save.
  3. Verify the list immediately displays the new name without reopening the file or page.
  4. Repeat with a file loaded when the page opens.
  5. Rename the same file again and verify the name updates each time.
  6. Cancel a rename and verify the displayed name matches the retained value.
  7. Verify downloading, removing files, and image previews still work.

🤖 Generated with Claude Code

@avapk
avapk requested a review from a team as a code owner October 28, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant