Repository navigation
chore: migrate to Node 26 LTS - #2500
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
r0b1n
previously approved these changes
Oct 30, 2026
gjulivan
previously approved these changes
Oct 30, 2026
iobuhov
previously approved these changes
Oct 30, 2026
leonardomendix
previously approved these changes
Oct 30, 2026
Update .nvmrc, engines field, and @types/node overrides from Node 24 to 26. CI workflows pick this up automatically via node-version-file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samuelreichert
force-pushed
the
chore/node-26-lts
branch
from
October 30, 2026 10:05
7bbf3a7 to
68300ed
Compare
This comment has been minimized.
This comment has been minimized.
Node 26 removed the `recursive` option of `fs.rmdir`. cross-zip 4.0.1
(latest release) still calls `fs.rmdir(outPath, { recursive: true })`
before zipping on Windows, so building the charts-web mpk failed with
ERR_INVALID_ARG_VALUE. Patch it to use `fs.rm` with `force: true`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samuelreichert
dismissed stale reviews from r0b1n, gjulivan, iobuhov, and leonardomendix
via
October 30, 2026 11:18
4f4b15b
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): lockfile contents beyond the paired changes. CI: pending: Plan E2E matrix, Run code quality check, sigridci, Snyk Code · unrelated failures: security/snyk (external scanner) Questions
Positives
|
r0b1n
approved these changes
Oct 30, 2026
gjulivan
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Dependency changes (any modification to dependencies in
package.json)Description
Migrate the repo to Node 26, the new Active LTS (26.13.0 "Lithium", released 2026-10-28).
.nvmrc:24.12.0→26.13.0(CI workflows read it vianode-version-file)package.jsonengines.node:>=24→>=26@types/nodeoverride:~24.12.0→~26.6.0;^24.0.0→^26.0.0inautomation/e2e-mcpandautomation/marketplace-mcpAGENTS.md: development setup note updatedpatches/cross-zip@4.0.1.patch: Node 26 removed therecursiveoption offs.rmdir, whichcross-zip4.0.1 (latest release) calls on Windows before zipping. This broke the charts-web mpk build in the Windows release task withERR_INVALID_ARG_VALUE. The patch switches tofs.rm(..., { recursive: true, force: true }).pnpm-lock.yaml: regenerated; only@types/node(24.12.4 → 26.6.6) and itsundici-typesdependency changedVerified locally on Node 26.13.0:
pnpm install(incl.canvasand@swc/corenative builds),tscfore2e-mcp,marketplace-mcp, andutils, plus build and unit tests forcombobox-web(61 tests) anddatagrid-web(263 tests).🤖 Generated with Claude Code