Skip to content

[WC-3418]: Fix combobox accessibility issues - #2513

Open
iobuhov wants to merge 3 commits into
mainfrom
claude/charming-euler-hidye1
Open

iobuhov wants to merge 3 commits into
mainfrom
claude/charming-euler-hidye1

Conversation

@iobuhov

@iobuhov iobuhov commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Mark the decorative down-arrow and clear-button SVGs as aria-hidden so screen readers no longer announce them as images, and skip rendering the no-options option when there is no text, so an empty combobox exposes no empty node.

Pull request type

Bug fix (non-breaking change which fixes an issue)

🤖 Generated with Claude Code

@iobuhov
iobuhov requested a review from a team as a code owner November 4, 2026 15:04
@github-actions

This comment has been minimized.

…ive tech

Mark the decorative down-arrow and clear-button SVGs as aria-hidden so screen
readers no longer announce them as images, and skip rendering the no-options
option when there is no text, so an empty combobox exposes no empty node.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZAW6LGnWBWa2De3ZYofRG
@iobuhov
iobuhov force-pushed the claude/charming-euler-hidye1 branch from bd2f5b4 to 6c2e10d Compare November 10, 2026 16:32
@github-actions

This comment has been minimized.

…configured

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

This comment has been minimized.

gjulivan
gjulivan previously approved these changes Nov 16, 2026
…s and label fallbacks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
combobox-web/src/assets/icons.tsx aria-hidden and focusable="false" on the decorative clear and down-arrow SVGs
combobox-web/src/components/Placeholder.tsx NoOptionsPlaceholder renders nothing when its text is blank
combobox-web/src/Combobox.tsx, helpers/utils.ts textOrFallback helper. Default clear and remove aria labels. No-options status message falls back to a11yNoOptions
combobox-web/src/Combobox.xml, typings/ComboboxProps.d.ts, Combobox.editorPreview.tsx New optional a11yNoOptions textTemplate property, typings and preview
combobox-web/src/**/__tests__, snapshots, e2e/*.spec.js New unit tests, updated snapshots, updated E2E expectations
combobox-web/CHANGELOG.md Entries under [Unreleased]

Skipped (out of scope): generated snapshot contents beyond a sanity check.

CI: not checked by me. This review didn't read gh pr checks.


Questions

  • When the combobox type is Boolean, noOptionsText is hidden in Combobox.editorConfig.ts. Should the new a11yNoOptions property be hidden there too, if boolean comboboxes can never be empty?

Positives

  • The change is additive and non-breaking. The new XML property is optional and uses a lowerCamelCase key. The typings and the editor preview are updated to match.
  • The new unit tests check what users can observe: the accessible button names, whether an option role is present, and the status message text. The wrapper test pairs the empty and whitespace cases with a case where the text is set.
  • The changelog entries describe behavior in the repo's voice.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants