Repository navigation
[WC-3666]: update react-dropzone to v20.1.4 - #2515
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
chore/bump-react-dropzone
branch
from
November 16, 2026 23:08
6ed85d6 to
3a6ebd1
Compare
This comment has been minimized.
This comment has been minimized.
r0b1n
approved these changes
Nov 18, 2026
gjulivan
force-pushed
the
chore/bump-react-dropzone
branch
from
November 18, 2026 10:30
3a6ebd1 to
1ac6a13
Compare
This comment has been minimized.
This comment has been minimized.
r0b1n
previously approved these changes
Nov 18, 2026
gjulivan
force-pushed
the
chore/bump-react-dropzone
branch
from
November 18, 2026 21:10
8661638 to
8ebb746
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
leonardomendix
previously approved these changes
Nov 19, 2026
Bump react-dropzone from 14.4.1 to 20.1.4 in file-uploader-web and rich-text-web. Regenerate the isExt patch for the new dist layout (dist/index.js, dist/index.cjs), since the upstream regex is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rowser type react-dropzone 18+ only guesses a file type from a small built-in table. Pass file-selector's COMMON_MIME_TYPES through getFilesFromEvent so files such as .log, .yaml, .flac, .mkv and .odt still match their format. Also document the react-dropzone 20 behavior changes in the File Uploader and Rich Text changelogs: wildcard MIME types narrowed by extensions, paste to upload, and hyphenated extensions now accepted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gjulivan
force-pushed
the
chore/bump-react-dropzone
branch
from
November 19, 2026 13:55
1afebba to
bcf566b
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
chore/bump-react-dropzone
branch
from
November 19, 2026 13:59
bcf566b to
143e5b2
Compare
leonardomendix
approved these changes
Nov 19, 2026
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): CI: pending: sigridci · unrelated failures: security/snyk (external scanner, 16 tests; not tied to this diff, but worth a look because this is a dependency bump) Findings
|
r0b1n
approved these changes
Nov 19, 2026
iobuhov
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Dependency changes (any modification to dependencies in
package.json)Description
Updates
react-dropzonefrom 14.4.1 to 20.1.4 infile-uploader-webandrich-text-web. This also brings inattr-accept4.0.1 andfile-selector5.0.2, and dropsprop-types.The local patch
patches/react-dropzone.patch(stricterisExtextension check) is still needed, because 20.1.4 has the same regex. v16 removeddist/es/and the UMD build, so the patch now targetsdist/index.js,dist/index.cjsandsrc/utils/index.ts.Breaking changes from 15 to 20, checked against our code:
isDragRejectcleared after drop: no impact. Both widgets read it only together withisDragActive.file-selector5 still includes a default table that covers all of them, so files the browser leaves without a type are still accepted. Only a custom format with an uncommon MIME type and no extensions loses that fallback.multiple: false. When several images are dropped at once, the first one is now used; before, nothing happened. This is in the changelog. File Uploader sets no file limit, so it is not affected.Unit tests pass (File Uploader 137/137, Rich Text 605/605), lint has no errors, and both widgets build with the patched regex in the bundle.
What should be covered while testing?
SecurityErrorfromFileSystemFileHandle.getFilein the console. If possible, also try the new web-based Outlook.🤖 Generated with Claude Code