fix(check): renumber the menu-icon rule to MDL077, off a collision

MDL074 was assigned twice: validate_navigation_icons.go (a menu item with
no icon) and validate_create_shape.go (an unqualified CREATE). Both are
live and both emit, so suppressing or looking up either by id hits the
other. Two PRs each read the highest assigned id and took the next one,
independently, before either merged.

MDL075 (void-with-alias) and MDL076 (ON ERROR CONTINUE where Mendix
refuses it) are taken as well, so the menu-icon rule moves to MDL077 --
create-shape keeps MDL074, having the wider blast radius in scripts and
docs already written against it.

Verified with a control rather than by grep, since a single rule
legitimately emits from several sites and a naive count cannot tell that
from a collision: the untouched repro (every item iconed) reports 0 rule
hits, the same file with two icons removed reports exactly 2 x MDL077,
and the unqualified-CREATE probe still reports MDL074 alone.

Nothing in the build catches a duplicate rule id; that guard does not
exist yet.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: ako

.claude/skills/mendix/manage-navigation/SKILL.md

@@ -119,7 +119,7 @@ create or replace navigation Responsive
 ### Menu Icons
 
 **Give every menu item an icon.** It is optional in the grammar and `mxcli check`
-warns when it is missing (**MDL074**), because the navigation sidebar collapses
+warns when it is missing (**MDL077**), because the navigation sidebar collapses
 to an icon rail and that is the state most users leave it in: a collapsed item
 shows its icon, and one without falls back to the first few characters of its
 caption — rarely enough to tell `Orders` from `Order lines`. Nothing else catches

docs/01-project/MDL_QUICK_REFERENCE.md

@@ -775,7 +775,7 @@ create or replace navigation Responsive
   );
 ```
 
-**An item with no icon is reported (MDL074, a warning).** The navigation sidebar
+**An item with no icon is reported (MDL077, a warning).** The navigation sidebar
 collapses to an icon rail, and that is the state most users leave it in: a
 collapsed item shows its icon, and one without falls back to the first few
 characters of its caption — rarely enough to tell `Orders` from `Order lines`.

mdl-examples/bug-tests/navigation-menu-item-icons.mdl

@@ -1,5 +1,5 @@
 -- ============================================================================
--- MDL074: a navigation menu item with no icon is reported
+-- MDL077: a navigation menu item with no icon is reported
 -- ============================================================================
 --
 -- The navigation sidebar collapses to an icon rail, and that is the state most
@@ -11,7 +11,7 @@
 -- This script is a POSITIVE example — every item carries an icon, so it checks
 -- clean. The warning it guards against is exercised by the unit tests in
 -- mdl/executor/validate_navigation_icons_test.go, which can assert the absence
--- of a warning as well as its presence; a `.fail.mdl` cannot, because MDL074 is
+-- of a warning as well as its presence; a `.fail.mdl` cannot, because MDL077 is
 -- a WARNING and `check` still exits 0.
 --
 -- The rule needs no project, so it fires under `make check-mdl` too.

mdl/executor/validate_navigation_icons.go

@@ -10,7 +10,7 @@ import (
 	"github.com/mendixlabs/mxcli/mdl/types"
 )
 
-// validateMenuItemIcons (MDL074) flags a navigation menu item that specifies no
+// validateMenuItemIcons (MDL077) flags a navigation menu item that specifies no
 // icon.
 //
 // # Why this is worth a warning
@@ -68,7 +68,7 @@ func validateMenuItemIcons(stmt ast.Statement) []linter.Violation {
 			// kind, which is what the writer and DESCRIBE also read.
 			if item.IconKind == types.MenuIconNone {
 				out = append(out, linter.Violation{
-					RuleID:   "MDL074",
+					RuleID:   "MDL077",
 					Severity: linter.SeverityWarning,
 					Message: fmt.Sprintf(
 						"%s: menu item %q specifies no icon — a collapsed navigation sidebar "+

mdl/executor/validate_navigation_icons_test.go

@@ -14,7 +14,7 @@ import (
 func navIconWarnings(vs []linter.Violation) []linter.Violation {
 	var out []linter.Violation
 	for _, v := range vs {
-		if v.RuleID == "MDL074" {
+		if v.RuleID == "MDL077" {
 			out = append(out, v)
 		}
 	}
@@ -140,7 +140,7 @@ func TestValidateMenuItemIcons_RunsWithoutAProject(t *testing.T) {
 		},
 	}}
 	if got := navIconWarnings(ValidateProgram(prog, "")); len(got) != 1 {
-		t.Errorf("got %d MDL074 from ValidateProgram with no project, want 1: %+v", len(got), got)
+		t.Errorf("got %d MDL077 from ValidateProgram with no project, want 1: %+v", len(got), got)
 	}
 }
 

mdl/executor/validate_program.go

@@ -53,7 +53,7 @@ func ValidateProgram(prog *ast.Program, projectPath string) []linter.Violation {
 			violations = append(violations, ValidateUserRoleSystemModuleRole(roleStmt, securityEnabled)...)
 		}
 		// A navigation menu item with no icon is unreadable once the sidebar is
-		// collapsed to its icon rail (MDL074). Covers both statements that carry
+		// collapsed to its icon rail (MDL077). Covers both statements that carry
 		// menu items, which share one AST node so they cannot diverge.
 		violations = append(violations, validateMenuItemIcons(stmt)...)
 		// A page with parameters and a Url must name each parameter in it (CE5601).

mdl/types/navigation.go

@@ -71,7 +71,7 @@ type NavMenuItem struct {
 // HasIcon reports whether the item carries an icon of ANY of the three kinds.
 //
 // Not `Icon != ""`: a glyph icon has a numeric code and no name, so the obvious
-// test calls an item with a perfectly good icon iconless. MDL074 asks this
+// test calls an item with a perfectly good icon iconless. MDL077 asks this
 // question, and asking it the obvious way would have made the rule fire on every
 // Studio Pro-authored menu.
 func (m *NavMenuItem) HasIcon() bool {

mdl/types/navigation_icon_test.go

@@ -6,7 +6,7 @@ import "testing"
 
 // A menu item's icon is one of three Mendix elements, and mxcli could name only
 // one of them. MenuIconKindOf maps the storage $Type onto a vocabulary so the
-// readers, the writers, DESCRIBE and MDL074 all decide the same way instead of
+// readers, the writers, DESCRIBE and MDL077 all decide the same way instead of
 // each doing its own strings.HasSuffix.
 func TestMenuIconKindOf(t *testing.T) {
 	cases := []struct {
@@ -52,7 +52,7 @@ func TestMenuIconStorageType(t *testing.T) {
 	}
 }
 
-// HasIcon is what MDL074 asks. A glyph icon carries a numeric code and NO name,
+// HasIcon is what MDL077 asks. A glyph icon carries a numeric code and NO name,
 // so a check written as `Icon == ""` reports an item that plainly has an icon.
 func TestNavMenuItemHasIcon(t *testing.T) {
 	cases := []struct {

mdl/visitor/visitor_navigation_icon_test.go

@@ -163,7 +163,7 @@ func TestNavMenuItem_BareIconIsStillACollectionIcon(t *testing.T) {
 	}
 }
 
-// An item with no icon at all keeps the zero kind, which is what MDL074 reads.
+// An item with no icon at all keeps the zero kind, which is what MDL077 reads.
 func TestNavMenuItem_NoIconIsKindNone(t *testing.T) {
 	items := navMenuItems(t, `MENU ITEM 'Home' PAGE M.Home;`)
 	if items[0].IconKind != types.MenuIconNone {