Notify the app when a CLI command changes node identity or position - #3392
Open
jbrazio wants to merge 1 commit into
Open
Notify the app when a CLI command changes node identity or position#3392jbrazio wants to merge 1 commit into
jbrazio wants to merge 1 commit into
Conversation
set name, set lat, set lon and gps setloc now fire a new no-op CommonCLICallbacks::onNodeConfigChanged() hook so the application can react to the change (e.g. re-evaluate automatic region or advert configuration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set name,set lat,set lonandgps setlocupdate the prefs and save them, but the app never hears about it. Anything the app derives from identity or position only catches up after a reboot.Adds a virtual no-op
onNodeConfigChanged()to the CommonCLI callbacks and fires it after those four commands succeed.