Skip to content

Commit b8a0abb

Browse files
committed
docs(drift): document cnn drift evaluation outcome
Time-boxed review (30 min): upstream preserves only the outer smartassetcontainer attribution paragraph while stripping the nested iframe/script payload. Matching that behavior would need a site-specific 'attribution-bearing embed wrapper' heuristic, which would risk regressing other widget/embed fixtures (calculators, social embeds, chart containers). Decision: leave the drift in place; expand the rationale in known-upstream-drift.json and README so the next reviewer does not re-investigate from scratch.
1 parent 5699647 commit b8a0abb

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

‎README.md‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,13 @@ correct for this port or would break pinned fixtures.
5555
parser-inserted `<tbody>`. Many pinned fixtures contain explicit `<tbody>`
5656
markup, so this needs an implicit-vs-explicit table-section strategy before
5757
changing serialization.
58-
- `cnn`: current upstream keeps a small SmartAsset attribution block that this
59-
port currently removes during cleanup.
58+
- `cnn`: current upstream keeps the outer `smartassetcontainer` (with only the
59+
"Powered by SmartAsset.com" attribution paragraph) while stripping the nested
60+
iframe/script payload. This port's embed cleanup removes the whole subtree.
61+
Reviewed under a 30-minute time box: replicating upstream would require a
62+
site-specific "attribution-bearing embed wrapper" heuristic that risks
63+
regressing other widget/embed fixtures (calculators, social embeds, chart
64+
containers), so the drift is intentionally left in place.
6065

6166
## Project Position
6267

‎tools/known-upstream-drift.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"cnn": {
33
"fields": ["content", "textContent"],
4-
"reason": "current upstream keeps a small SmartAsset attribution block that this port removes with the embed"
4+
"reason": "current upstream keeps the outer smartassetcontainer (only the 'Powered by SmartAsset.com' attribution paragraph) while stripping the nested iframe/script payload. This port's embed cleanup removes the whole subtree. Replicating upstream would require a site-specific 'attribution-bearing embed wrapper' heuristic that risks regressing other widget/embed fixtures (calculators, social embeds, chart containers); reviewed and left as drift."
55
},
66
"firefox-nightly-blog": {
77
"fields": ["byline", "content", "textContent"],

0 commit comments

Comments
 (0)