Repository navigation
fix: include ESP32-S3 in default static library generation targets - #2046
Open
yousseffaouzi wants to merge 2 commits into
Open
yousseffaouzi wants to merge 2 commits into
yousseffaouzi wants to merge 2 commits into
Conversation
Add esp32s3 to the default platform set so ordinary library-generation runs produce the target already supported by the explicit build path. Explicit -p target selection remains unchanged. Refs micro-ROS#2041 Signed-off-by: Youssef Faouzi <46967695+yousseffaouzi@users.noreply.github.com>
Follow the repository contribution requirement to record the contributor identity using the GitHub no-reply address. Signed-off-by: Youssef Faouzi <46967695+yousseffaouzi@users.noreply.github.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2041.
esp32s3to the default platform list inextras/library_generation/library_generation.sh.-p esp32and-p esp32s3selection.NOTICEas required by the contribution guidelines.Validation
Passed:
Not tested: Full Docker/ROS cross-compilation and physical hardware. These require additional verification.
Both commits include DCO sign-off.