Repository navigation
Reduce WiFi transport receive timeout to 1 ms (backport #104) - #105
Merged
Merged
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit f49d620)
Contributor
Author
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sockets wrapper used fix the receive timeout when the socket is connected, so every
TCP_Sockets_Recvblocks up to that value regardless of the timeout requested by the XRCE session. With 10 ms, each read on an idle link costs 10 ms.Since micro-ROS/rmw_microxrcedds#343 and micro-ROS/rmw_microxrcedds#347,
rmw_waittries to read twice per spin with non-zero timeouts, which limitsPublisherRateTestover WiFi/TCP to ~50 Hz and makes it fail.Use 1 ms so the existing read loop honors the requested timeout again.
This is an automatic backport of pull request #104 done by Mergify.