Skip to content

Reduce WiFi transport receive timeout to 1 ms (backport #104) - #107

Merged
David-LP99 merged 1 commit into
humblefrom
mergify/bp/humble/pr-104
Oct 15, 2026
Merged

David-LP99 merged 1 commit into
humblefrom
mergify/bp/humble/pr-104

Conversation

@mergify

@mergify mergify Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Description

The sockets wrapper used fix the receive timeout when the socket is connected, so every TCP_Sockets_Recv blocks up to that value regardless of the timeout requested by the XRCE session. With 10 ms, each read on an idle link costs 10 ms.

Since micro-ROS/rmw_microxrcedds#343 and micro-ROS/rmw_microxrcedds#347, rmw_wait tries to read twice per spin with non-zero timeouts, which limits PublisherRateTest over WiFi/TCP to ~50 Hz and makes it fail.

Use 1 ms so the existing read loop honors the requested timeout again.


This is an automatic backport of pull request #104 done by Mergify.

@mergify mergify Bot added the conflicts label Oct 7, 2026
@mergify

mergify Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of f49d620 has failed:

On branch mergify/bp/humble/pr-104
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit f49d620.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   extra_sources/microros_transports/wifi_transport_freeRTOS.c

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify

mergify Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor Author

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@David-LP99
David-LP99 force-pushed the mergify/bp/humble/pr-104 branch from 09705d0 to 0926874 Compare October 15, 2026 05:33
@David-LP99
David-LP99 merged commit 8eaddde into humble Oct 15, 2026
2 checks passed
@David-LP99
David-LP99 deleted the mergify/bp/humble/pr-104 branch October 15, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant