Revamp increment_auto_off.py to be more efficient

Author: SteveMicroNova

scripts/increment_auto_off.py

@@ -20,34 +20,28 @@
     response = requests.get('http://localhost:5001/settings/persist_logs', timeout=10)
     state = response.json()
 
-    if state["persist_logs"] and state["auto_off_delay"] > 0:
-      body: dict
-      if state["auto_off_delay"] >= 1:
-        delay = state["auto_off_delay"] - 1
-        body = {
-          "persist_logs": True,
-          "auto_off_delay": delay,
-        }
+    future_persist_state = state["auto_off_delay"] != 1
+    delay = state["auto_off_delay"] - 1
+    body = {
+      "persist_logs": future_persist_state,
+      "auto_off_delay": delay if future_persist_state else 14,  # If no longer persisting, set to default
+    }
+    json_data = json.dumps(body)
+    response = requests.post(
+      url='http://localhost:5001/settings/persist_logs',
+      headers={'Content-Type': 'application/json'},
+      data=json_data,
+      timeout=10,
+    )
+
+    if response.ok:
+      loop = False
+      if future_persist_state:
         logging.info(f"Persist logs will be automatically turned off in {delay} day(s)")
       else:
-        body = {
-          "persist_logs": False,
-          "auto_off_delay": 14,  # Reset to default for next time
-        }
         logging.info("Persist logs has been turned off automatically")
-
-      json_data = json.dumps(body)
-      response = requests.post(
-        url='http://localhost:5001/settings/persist_logs',
-        headers={'Content-Type': 'application/json'},
-        data=json_data,
-        timeout=10,
-      )
-
-      if response.ok:
-        loop = False
   except Exception as exc:
-    logger.exception(f"Auto off increment has failed with the following exception, trying again in 5 seconds: {exc}")
+    logger.exception(f"increment_auto_off.py has failed with the following exception, trying again in 5 seconds: {exc}")
   finally:
     if loop:
       time.sleep(5)  # Loop until there is a response.ok at the end