fix(web): stabilize player album art sizing - #1110
Open
pollychen-lab wants to merge 1 commit into
Open
pollychen-lab wants to merge 1 commit into
pollychen-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
Closes #1103.
This keeps the player page metadata column stable when album art is missing or fails to load by reserving a square album-art area in CSS. The player metadata width now comes from a reusable class instead of the prior inline style, and the album art scales within the reserved area with a 98vw cap for narrow mobile screens.
Validation
npm run buildfromweb/npx eslint src/pages/Player/Player.jsxfromweb/(currently fails on existing formatting inPlayer.jsx: semicolons, indentation, and quote style outside this CSS sizing change)Checklist
./scripts/test