Fido: Make activity opaque

Author: mar-v-in

play-services-fido/core/src/main/AndroidManifest.xml

@@ -67,7 +67,6 @@
             android:excludeFromRecents="true"
             android:configChanges="smallestScreenSize|screenSize|uiMode|screenLayout|orientation|keyboardHidden|keyboard"
             android:launchMode="singleTask"
-            android:noHistory="true"
             tools:targetApi="23">
             <intent-filter android:icon="@drawable/ic_fido_passkey">
                 <action android:name="android.intent.action.VIEW"/>

play-services-fido/core/src/main/kotlin/org/microg/gms/fido/core/ui/AuthenticatorActivity.kt

@@ -5,6 +5,7 @@
 
 package org.microg.gms.fido.core.ui
 
+import android.app.Activity
 import android.content.Intent
 import android.graphics.Color
 import android.graphics.drawable.ColorDrawable
@@ -182,6 +183,7 @@ class AuthenticatorActivity : AppCompatActivity(), TransportHandlerCallback {
                 }
             }
 
+            makeOpaque()
             runCatching { setAuthenticatorUiBackgroundOpaque() }
 
             val arguments = AuthenticatorActivityFragmentData().apply {
@@ -342,6 +344,21 @@ class AuthenticatorActivity : AppCompatActivity(), TransportHandlerCallback {
         return shouldStartTransportInstantly(SCREEN_LOCK)
     }
 
+    private fun makeOpaque() {
+        if (SDK_INT >= 30) {
+            setTranslucent(false)
+        } else {
+            try {
+                // Internal framework method present in SDK < 30
+                val method = Activity::class.java.getDeclaredMethod("convertFromTranslucent")
+                method.isAccessible = true
+                method.invoke(this)
+            } catch (e: Exception) {
+                Log.w(TAG, "Failed to make opaque", e)
+            }
+        }
+    }
+
     @RequiresApi(21)
     private fun setAuthenticatorUiBackgroundOpaque() {
         // FIXME: When we migrate to bottom sheet, revisit all the theming matters

play-services-fido/core/src/main/kotlin/org/microg/gms/fido/core/ui/hybrid/HybridAuthenticateActivity.kt

@@ -117,7 +117,7 @@ class HybridAuthenticateActivity : AppCompatActivity() {
 
     @RequiresPermission(Manifest.permission.BLUETOOTH_ADVERTISE)
     private fun startHybridConnectionFlow() {
-        lifecycleScope.launchWhenStarted {
+        lifecycleScope.launchWhenCreated {
             hybridAuthenticatorController = hybridAuthenticatorController ?: HybridAuthenticatorController(this@HybridAuthenticateActivity)
             try {
                 hybridAuthenticatorController?.startAuth(qrCodeData!!, handleAuthenticator = {