Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Handle an empty
LocationResultbefore reading coordinates in the live location sharing callback.LocationResult.getLastLocation()returns null when its list is empty; the existing code readlatitudebefore its later null check, causing aNullPointerExceptionand skipping the callback's normal handling.The callback now returns for a missing location. Non-empty results follow the existing logging and upload path.
Evidence
LocationSharingUpdate.ktasUncertain Nullable Platform Caller(possible bug,MEDIUM) in upstream commit32bc8954ff872d0e1a05ddfae81561b6dbecef69.LocationResult.getLastLocation()documents and implements the empty-list return as null.LocationResult/LocationCallbackreproduced the NPE for an empty result. A local fixed copy completed safely for empty and non-empty results.Closes #3889
Validation limits
The reproduction uses stubs for Android and unrelated service boundaries; it does not claim a full Android instrumentation run or a full Gradle build. No behavior outside the null guard is changed.