Fix CreateOrderSaga completion and LazyInitializationException in order operations

- Add EventuateLocal CDC pipeline for accounting service alongside Tram pipeline
  The accounting service uses event sourcing (events table) for domain events
  but also needs the Tram pipeline (message table) for saga replies.
  Both pipelines share reader5.

- Fix LazyInitializationException in OrderServiceImpl.reviseOrder() and cancel()
  by eagerly loading orderLineItems within the transaction

- Remove unnecessary saga lock from KitchenServiceCommandHandler.createTicket()

Co-authored by Claude Code

Author: cer

ftgo-end-to-end-tests/src/endToEndTest/java/net/chrisrichardson/ftgo/endtoendtests/ApplicationUnderTestUsingTestContainers.java

@@ -90,19 +90,26 @@ public ApplicationUnderTestUsingTestContainers() {
         apiGateway = createApiGatewayContainer();
 
         // CDC service
+        // Note: Accounting service needs BOTH pipelines:
+        // - Tram pipeline (message table) for sending saga replies
+        // - EventuateLocal pipeline (events table) for publishing domain events
+        // Both pipelines share the same reader (reader5)
         cdc = new EventuateCdcContainer()
                 .withKafka(kafka)
                 .withKafkaLeadership()
-                .withTramPipeline(consumerDatabase)
-                .withTramPipeline(orderDatabase)
-                .withTramPipeline(kitchenDatabase)
-                .withTramPipeline(restaurantDatabase)
-                .withTramPipeline(accountingDatabase)
-                .withTramPipeline(deliveryDatabase)
+                .withTramPipeline(consumerDatabase)   // reader1, pipeline1
+                .withTramPipeline(orderDatabase)      // reader2, pipeline2
+                .withTramPipeline(kitchenDatabase)    // reader3, pipeline3
+                .withTramPipeline(restaurantDatabase) // reader4, pipeline4
+                .withTramPipeline(accountingDatabase) // reader5, pipeline5 (Tram for saga replies)
+                .withTramPipeline(deliveryDatabase)   // reader6, pipeline6
                 .withReuse(false)
                 .withExposedPorts(8080)
                 .dependsOn(consumerService, orderService, kitchenService, restaurantService, accountingService, deliveryService)
                 .withLogConsumer(new Slf4jLogConsumer(logger).withPrefix("cdc:"));
+
+        // Add EventuateLocal pipeline for accounting service (reuses reader5, new pipeline7)
+        addEventuateLocalPipelineUsingExistingReader(cdc, 5, 7);
     }
 
     private EventuateDatabaseContainer<?> createDatabase(String alias) {
@@ -164,6 +171,20 @@ private GenericContainer<?> createApiGatewayContainer() {
                 .withLogConsumer(new Slf4jLogConsumer(logger).withPrefix("api-gateway:"));
     }
 
+    /**
+     * Adds an EventuateLocal pipeline that reuses an existing reader.
+     * This allows the same database to have both Tram and EventuateLocal pipelines.
+     */
+    private void addEventuateLocalPipelineUsingExistingReader(EventuateCdcContainer cdc, int readerIdx, int pipelineIdx) {
+        String pipelinePrefix = "EVENTUATE_CDC_PIPELINE_PIPELINE" + pipelineIdx + "_";
+
+        // Pipeline configuration - uses eventuate-local type and existing reader
+        // Note: accounting-service uses schema=public (per its application.properties)
+        cdc.withEnv(pipelinePrefix + "TYPE", "eventuate-local");
+        cdc.withEnv(pipelinePrefix + "READER", "reader" + readerIdx);
+        cdc.withEnv(pipelinePrefix + "EVENTUATEDATABASESCHEMA", "public");
+    }
+
     @Override
     public void start() {
         kafka.withLogConsumer(new Slf4jLogConsumer(logger).withPrefix("kafka:"));

ftgo-kitchen-service/kitchen-service-command-handlers/src/main/java/net/chrisrichardson/ftgo/kitchenservice/messagehandlers/KitchenServiceCommandHandler.java

@@ -47,7 +47,7 @@ private Message createTicket(CommandMessage<CreateTicket>
     try {
       Ticket ticket = kitchenService.createTicket(restaurantId, ticketId, ticketDetails);
       CreateTicketReply reply = new CreateTicketReply(ticket.getId());
-      return withLock(Ticket.class, ticket.getId()).withSuccess(reply);
+      return withSuccess(reply);
     } catch (RestaurantDetailsVerificationException e) {
       return withFailure();
     }

ftgo-kitchen-service/src/main/java/net/chrisrichardson/ftgo/kitchenservice/messagehandlers/KitchenServiceCommandHandler.java

@@ -47,7 +47,7 @@ private Message createTicket(CommandMessage<CreateTicket>
     try {
       Ticket ticket = kitchenService.createTicket(restaurantId, ticketId, ticketDetails);
       CreateTicketReply reply = new CreateTicketReply(ticket.getId());
-      return withLock(Ticket.class, ticket.getId()).withSuccess(reply);
+      return withSuccess(reply);
     } catch (RestaurantDetailsVerificationException e) {
       return withFailure();
     }

ftgo-order-service/order-service-main/src/main/java/net/chrisrichardson/ftgo/orderservice/domain/OrderServiceImpl.java

@@ -126,6 +126,8 @@ public Order cancel(Long orderId) {
             .orElseThrow(() -> new OrderNotFoundException(orderId));
     CancelOrderSagaData sagaData = new CancelOrderSagaData(order.getConsumerId(), orderId, order.getOrderTotal());
     sagaInstanceFactory.create(cancelOrderSaga, sagaData);
+    // Access lazy-loaded collections within transaction to avoid LazyInitializationException
+    order.getOrderTotal();
     return order;
   }
 
@@ -163,6 +165,8 @@ public Order reviseOrder(long orderId, OrderRevision orderRevision) {
     Order order = orderRepository.findById(orderId).orElseThrow(() -> new OrderNotFoundException(orderId));
     ReviseOrderSagaData sagaData = new ReviseOrderSagaData(order.getConsumerId(), orderId, null, orderRevision);
     sagaInstanceFactory.create(reviseOrderSaga, sagaData);
+    // Access lazy-loaded collections within transaction to avoid LazyInitializationException
+    order.getOrderTotal();
     return order;
   }