Skip to content

Reject non-finite --min-age in cleanup-grid-sessions.py #5883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eugene (OEvgeny) merged 1 commit into from
Oct 17, 2026
Merged

Reject non-finite --min-age in cleanup-grid-sessions.py #5883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/skills/webchat-html-tests/scripts/cleanup-grid-sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import argparse
import json
import math
import os
import sys
import urllib.error
Expand Down Expand Up @@ -29,7 +30,10 @@ def parse_arguments():

arguments = parser.parse_args()

arguments.min_age is not None and arguments.min_age < 0 and parser.error('--min-age must not be negative')
# `float()` accepts "nan" and "inf", which break the age comparison, e.g. `age < nan` is always false.
arguments.min_age is not None and not (
math.isfinite(arguments.min_age) and arguments.min_age >= 0
) and parser.error('--min-age must be a finite number of seconds, zero or more')

return arguments

Expand Down
Loading