Repository navigation
Add testing guidance on snapshots and waitFor to AGENTS.md - #5885
Merged
Merged
Conversation
Eugene (OEvgeny)
marked this pull request as ready for review
October 17, 2026 06:48
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 17, 2026 06:48
William Wong (compulim)
approved these changes
Oct 17, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both additions match the referenced testing guidance and change no runtime behavior.
No open issues 🎉
What changed in this PR
Documents two testing practices in AGENTS.md to improve visual checks and reduce flaky asynchronous assertions.
Changes:
- Prefer snapshots for visual verification and assertions for state.
- Use
waitFor()withexpectfor asynchronous effects instead of sleeps.
| File | Description |
|---|---|
| AGENTS.md | Adds snapshot and asynchronous assertion guidance. |
Review effort: Balanced
Eugene (OEvgeny)
enabled auto-merge (squash)
October 17, 2026 07:32
Eugene (OEvgeny)
disabled auto-merge
October 17, 2026 07:44
Eugene (OEvgeny)
enabled auto-merge (squash)
October 17, 2026 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Not required, development only.
Description
Two testing practices that came up repeatedly in recent reviews are not in
AGENTS.md, so agents keep missing them:This PR adds one bullet for each to "Testing instructions".
Specific Changes
AGENTS.md: two bullets under "Testing instructions": let snapshots verify visual changes and assert state instead of computed CSS; wait for asynchronous effects withwaitFor()from@testduet/wait-forI have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed