Repository navigation
Localize the "message" and "attachment" role descriptions - #5916
Merged
Merged
Conversation
2 of 11 tasks
Collaborator
Author
|
Collaborator
Author
|
TODO: show announced activities by applying styles to live region and taking snapshot |
Eugene (OEvgeny)
marked this pull request as ready for review
October 20, 2026 00:19
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 20, 2026 00:19
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-roledescription-l10n
branch
from
October 20, 2026 01:12
83e3777 to
5a98ec0
Compare
William Wong (compulim)
previously approved these changes
Oct 20, 2026
Eugene (OEvgeny)
dismissed
William Wong (compulim)’s stale review
via
October 20, 2026 18:32
a2f7438
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-roledescription-l10n
branch
2 times, most recently
from
October 20, 2026 20:24
a2f7438 to
ef11615
Compare
William Wong (compulim)
previously approved these changes
Oct 20, 2026
added 3 commits
October 20, 2026 13:56
Add ACTIVITY_MESSAGE_ARIA_ROLE_ALT and ACTIVITY_ATTACHMENT_ARIA_ROLE_ALT and use them for aria-roledescription of the message and attachment groups in stacked and carousel layouts, instead of hard-coded English.
Eugene (OEvgeny)
dismissed
William Wong (compulim)’s stale review
via
October 20, 2026 20:57
be7aeae
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-roledescription-l10n
branch
from
October 20, 2026 20:57
ef11615 to
be7aeae
Compare
William Wong (compulim)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
The
aria-roledescriptionof the message and attachment groups in stacked and carousel layouts was hard-coded in English. They now come from 2 new localized strings, which hosts can also set viaoverrideLocalizedStringsuntil translations arrive.Design
ACTIVITY_MESSAGE_ARIA_ROLE_ALTandACTIVITY_ATTACHMENT_ARIA_ROLE_ALT, named likeTRANSCRIPT_ARIA_ROLE_ALT; no existing string fits.localizefromCarouselFilmStripandStackedLayoutInner: git merges either order cleanly, so the PR merged second must keepconst localize = useLocalizer()in both (ESLint/tsc flag it otherwise).Specific Changes
en-US.json: added the 2 strings with commentsStackedLayout.tsx,AttachmentRow.tsx,CarouselFilmStrip.js,CarouselFilmStripAttachment.js: localizearia-roledescriptionAdded
accessibility/aria-roledescription.localized.html: asserts "message"/"attachment" in en-US, then "Nachricht"/"Anhang" with German overrides; snapshots 1–2 show the stacked and carousel messages and the live region copy, in English then GermanI have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed