Skip to content

Release nova-snark 0.75.0 with serde_with 3.21.0 - #508

Merged
Sai (sai-deng) merged 3 commits into
mainfrom
sai/serde-with-3.21
Aug 21, 2026
Merged

Release nova-snark 0.75.0 with serde_with 3.21.0#508
Sai (sai-deng) merged 3 commits into
mainfrom
sai/serde-with-3.21

Conversation

@sai-deng

@sai-deng Sai (sai-deng) commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • release nova-snark 0.75.0
  • pin serde_with to exactly 3.21.0
  • raise the declared MSRV to Rust 1.88, required by serde_with 3.21.0
  • make the MSRV job activate Rust 1.88 and check all supported non-GPU features
  • fix formatting required by current rustfmt

@srinathsetty

Copy link
Copy Markdown
Collaborator

Sai (@sai-deng) should we bump nova-snark version in this PR?

@sai-deng Sai (sai-deng) changed the title Pin serde_with 3.21.0 Release nova-snark 0.75.0 with serde_with 3.21.0 Aug 21, 2026
@sai-deng

Copy link
Copy Markdown
Contributor Author

Sai (Sai (@sai-deng)) should we bump nova-snark version in this PR?

Bump it to 0.75.0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Releases nova-snark 0.75.0 with serde_with 3.21.0 and Rust 1.88 MSRV support.

Changes:

  • Updates release metadata and dependency pinning.
  • Modernizes Rust APIs and formatting.
  • Adds MSRV CI coverage for non-GPU features.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/gadgets/ecc.rs Modernizes Option handling.
src/frontend/gadgets/sha256.rs Uses is_multiple_of.
src/frontend/gadgets/poseidon/circuit2.rs Uses repeat_n.
Cargo.toml Updates version, MSRV, and serde_with.
.github/workflows/rust.yml Adds Rust 1.88 MSRV validation.
Suppressed comments (1)

.github/workflows/rust.yml:41

  • The manifest also exposes flamegraph as a non-GPU feature (Cargo.toml:93), and the benchmark targets use it. Omitting it here means this MSRV job does not activate all supported non-GPU feature configurations promised by the PR; add flamegraph to the feature list (and include the benchmark targets if their MSRV is in scope).
          args: --lib --features "io,evm,experimental,test-utils"

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sai-deng
Sai (sai-deng) added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit 3d28710 Aug 21, 2026
14 checks passed
@sai-deng
Sai (sai-deng) deleted the sai/serde-with-3.21 branch August 21, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants