Repository navigation
FIX: keep the source video when audio extraction returns it unchanged - #3298
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3297
The video scorers unlink the extracted audio file after scoring it, but
AudioTranscriptHelper.extract_audio_from_videohands back the input path unchanged when the video's own audio track is already compliant WAV. In that case the cleanup deleted the original video the caller passed in. The unlink now skips the source file, matching the guard_transcribe_audio_asyncalready has for the same situation.Tests and Documentation
Added a regression test that mocks the extractor to return the video's own path and asserts the file still exists after scoring. It fails on main and passes with the change. The full video and audio scorer suites pass (51 tests).
No documentation change needed, so I did not run JupyText.