Repository navigation
FIX: derive csv header from the union of row keys - #3304
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3303
write_csvtook its fieldnames from the first row only, so a later row with an extra key madeDictWriterraise after the header and earlier rows were already written, leaving a truncated file behind. The header now comes from the union of keys across all rows in first-seen order, and rows missing a key get an empty cell.Tests and Documentation
Added two tests: one writes rows where only the second row has an extra key and asserts the round trip keeps every value, and one asserts the header keeps first seen column order when later rows introduce keys. Both fail on main and pass with the change. The full csv helper suite passes (9 tests).
No documentation change needed, so I did not run JupyText.