Removed Swagger - #25
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes Swagger documentation from the Manager API and updates various NuGet package versions across the solution to fix build issues. The changes modernize dependencies and remove API documentation tooling.
- Removed Swagger/OpenAPI documentation setup from Manager API
- Updated Azure.Identity and Microsoft.Identity.Client packages to newer versions
- Modernized build pipeline to use .NET 6.0 and NuGet 6.x
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple .csproj files | Updated Azure.Identity and Microsoft.Identity.Client package versions |
| LogClientInfoCommandHandler.cs | Removed duplicate using statement |
| Startup.cs (Manager/Web/App) | Updated authentication configuration to use Microsoft.Identity.Web |
| Startup.cs (Manager/Web/API) | Removed Swagger configuration and endpoints |
| Manager API .csproj | Removed Swagger packages and updated authentication packages |
| Manager Domain .csproj | Switched CQRS package and removed SDK project reference |
| azure-pipelines.yml | Updated to .NET 6.0 and NuGet 6.x with SSL dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\..\sdk\Microsoft.UnifiedRedisPlatform.SDK\Core\Microsoft.UnifiedRedisPlatform.Core.csproj" /> | ||
| <ProjectReference Include="..\..\..\..\service\Microsoft.UnifiedRedisPlatform.Service\SharedKernel\Common\Microsoft.UnifiedPlatform.Service.Common.csproj" /> |
There was a problem hiding this comment.
The project reference removal on line 11 may cause build issues if the Domain project depends on types from the Microsoft.UnifiedRedisPlatform.Core project. Verify that all dependencies are satisfied by the remaining references.
| <ProjectReference Include="..\..\..\..\service\Microsoft.UnifiedRedisPlatform.Service\SharedKernel\Common\Microsoft.UnifiedPlatform.Service.Common.csproj" /> | |
| <ProjectReference Include="..\..\..\..\service\Microsoft.UnifiedRedisPlatform.Service\SharedKernel\Common\Microsoft.UnifiedPlatform.Service.Common.csproj" /> | |
| <ProjectReference Include="..\..\..\..\core\Microsoft.UnifiedRedisPlatform.Core\Microsoft.UnifiedRedisPlatform.Core.csproj" /> |
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\sdk\Microsoft.UnifiedRedisPlatform.SDK\Core\Microsoft.UnifiedRedisPlatform.Core.csproj" /> | ||
| <ProjectReference Include="../../../sdk/Core/Microsoft.UnifiedRedisPlatform.Core.csproj" /> |
There was a problem hiding this comment.
The project reference path has been changed from Windows-style backslashes to forward slashes. While this works on most systems, ensure this path is correct and the referenced project exists at this location.
| <PackageReference Include="Microsoft.Graph.Auth" Version="1.0.0-preview.4" /> | ||
| <PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="5.2.8" /> | ||
| <PackageReference Include="Swashbuckle.AspNetCore" Version="5.4.1" /> | ||
| <PackageReference Include="Microsoft.Identity.Client" Version="4.73.1" /> |
There was a problem hiding this comment.
The Microsoft.IdentityModel.Clients.ActiveDirectory package was removed and replaced with Microsoft.Identity.Client. Ensure that any code using ADAL (Active Directory Authentication Library) has been migrated to MSAL (Microsoft Authentication Library) to avoid runtime errors.
|
merging PR |
Remmoved swagger usage
Fixed Build issues