Repository navigation
Python: Prefer injected Oracle clients over connection settings - #9985
Open
ZedingZhang (ZedingZhang) wants to merge 1 commit into
Open
ZedingZhang (ZedingZhang) wants to merge 1 commit into
ZedingZhang (ZedingZhang) wants to merge 1 commit into
Conversation
ZedingZhang (ZedingZhang)
temporarily deployed
to
github-app-auth
November 2, 2026 17:58 — with
GitHub Actions
Inactive
ZedingZhang (ZedingZhang)
marked this pull request as ready for review
November 2, 2026 17:58
ZedingZhang (ZedingZhang)
temporarily deployed
to
github-app-auth
November 2, 2026 17:59 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the change to prioritize injected Oracle clients while preserving caller ownership.
No open issues 🎉
What changed in this PR
Updates the Python Oracle vector-store integration so injected async connections and pools take precedence over connection settings, addressing #9961 while preserving caller ownership.
Changes:
- Removes the rejection of redundant connection, pool, and
.envoptions when a client is supplied. - Expands regression coverage for ignored settings, client reuse, cleanup, and invalid client types.
- Updates documentation to describe client precedence and ownership.
| File | Description |
|---|---|
python/packages/oracle/tests/oracle/test_settings.py |
Tests injected-client precedence across 32 combinations and retains invalid-client validation. |
python/packages/oracle/README.md |
Clarifies that supplied clients take precedence over connection settings. |
python/packages/oracle/agent_framework_oracle/_vector_store.py |
Removes the conflicting-settings check and updates constructor parameter documentation. |
Review effort: Balanced
ZedingZhang (ZedingZhang)
temporarily deployed
to
github-app-auth
November 2, 2026 18:01 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
OracleStoreandOracleCollectionreject connection and pool settings alongside an injected async connection or pool. Those settings are irrelevant to the supplied client, so applications cannot reuse their preconfigured client with shared constructor options.Description & Review Guide
.envoptions, including empty or invalid values. They remain caller-owned.Related Issue
Fixes #9961. The issue has the
ready-for-implementationlabel; no competing open PR was found before submission.AI Assistance
AI assistance details: Codex assisted with investigation, implementation, tests, parameter documentation, and this PR description. Codex executed the reported checks; I reviewed all submitted content and take responsibility for it.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.