Repository navigation
Commit f550cfb
fix: support Swift builds that use an Objective-C bridging header (#4364)
* fix: support Swift builds that use an Objective-C bridging header
Hosts can compile FURN's Swift sources against React Native through an
Objective-C bridging header instead of a `React` clang module.
- Import `React` in the Avatar and NativeDatePicker iOS Swift sources only
when the module is available.
- Implement the macOS Paper Callout `focusWindow` and `blurWindow` commands
in Swift and declare them with `RCT_EXTERN_METHOD`, so FRNCalloutManager.m
no longer imports the generated FRNNativeCore-Swift.h. With a bridging
header, that generated header also declares the internal RCTCalloutManager
class, which duplicates the `RCT_EXTERN_MODULE` interface.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ea215348-486c-45ef-8205-2a81a1dd75a7
* fix: import React Native headers with the <React/...> form in iOS sources
FRNAppearanceAdditions.m and FRNDatePickerManager.m included RCTUIManager.h
and RCTBridgeModule.h by bare name, which only resolves in hosts that also
expose React Native headers without the React/ prefix. Use the canonical
<React/...> form, which the rest of these files and CocoaPods already use.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ea215348-486c-45ef-8205-2a81a1dd75a7
* fix(native-core): import RCTI18nUtil.h with the <React/...> form in FocusZone
The macOS FocusZone implementation included "RCTi18nUtil.h" by bare name and
with different capitalization from React Native's React/Modules/RCTI18nUtil.h,
so it only resolved through a case-insensitive bare-name header map. Use the
canonical <React/RCTI18nUtil.h> form.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ea215348-486c-45ef-8205-2a81a1dd75a7
* fix(native-core): silence unused block parameter warnings in macOS FocusZone
Mark the unused `index` and `stop` parameters of the
indexOfObjectPassingTest: block in RCTFocusZone.m as `__unused` so the file
compiles cleanly when -Wunused-parameter is treated as an error.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d7aea072-fc8e-4a8d-890a-81311025130d
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ea215348-486c-45ef-8205-2a81a1dd75a7
Copilot-Session: d7aea072-fc8e-4a8d-890a-81311025130d1 parent 877c84f commit f550cfb
15 files changed
Lines changed: 71 additions & 31 deletions
File tree
- .changeset
- packages
- agentic/native-core
- macos/components
- Callout/paper
- tests
- experimental
- AppearanceAdditions/ios
- Avatar/ios
- NativeDatePicker/ios
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
44 | 48 | | |
45 | 49 | | |
46 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
16 | 31 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | 3 | | |
6 | 4 | | |
7 | 5 | | |
| |||
39 | 37 | | |
40 | 38 | | |
41 | 39 | | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
| 40 | + | |
52 | 41 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
| 42 | + | |
63 | 43 | | |
64 | 44 | | |
65 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
560 | 560 | | |
561 | 561 | | |
562 | 562 | | |
563 | | - | |
| 563 | + | |
564 | 564 | | |
565 | 565 | | |
566 | 566 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
60 | 68 | | |
61 | 69 | | |
62 | 70 | | |
| |||
0 commit comments