Skip to content

Infrastructure: Tighten Storybook manifest provenance and native helper trust handoff #4445

Open

Description

@JasonVMo

Current status - 2026-11-09

Unblocked. F2 #4442 is closed: its ownership and publication contract merged in #4463. None of the merged work delivers this trust hardening. Controlled ingress (F5 #4443, also #4463), the native-smoke fixes, and the F16 input policy do not substitute for it.

Remaining acceptance is unchanged:

  • Separate runtime-bridge and attach-credential secrets
  • Centralized, versioned generated schemas with unknown-field rejection
  • Independent helper provenance verification in the actual spawning process
  • Owner-private POSIX/Windows storage boundaries
  • Controlled Metro generation fixtures

A hash in the same editable manifest is not independent trust.

Keep the existing F3/F5/F6 server.cjs integration ordering. This issue is now the only open gate for F9 #4449; it does not require relocating the channel process first.

Goal

Native helper provenance crosses an editable generated manifest, the macOS attach lease and the runtime bridge reuse the same nonce, and generated schemas are not centralized or versioned. Tighten the trust handoff so tampered artifacts fail before spawn and each secret has one purpose.

Part of #4435 (plan item F6).

Scope

  • Owner: Storybook generated configuration.
  • Paths (under packages/agentic/): storybook-desktop/src/driver/driverManifest.ts, nonce and lease handling in storybook-desktop/src/cli/DesktopStorybookCli.ts, storybook-desktop/config/server.cjs, storybook-desktop-runtime/config/metro.cjs, and controlled config fixtures.
  • Separate runtime bridge and attach-credential secrets.
  • Centralize and version generated schemas; reject unknown manifest fields.
  • Reverify helper provenance in the process that actually spawns it. A hash stored in the same editable record is not independent trust.
  • Exercise Metro generation only in controlled fixtures, because loading its config has write effects.

Dependencies

Acceptance

  • Tampered or mismatched artifacts fail before spawn.
  • Unknown manifest fields fail.
  • Bridge and attach nonces are independent.
  • Secrets use owner-private POSIX modes and the appropriate Windows ACL or private-storage boundary.

Validation

  • Iterate with focused yarn test <name> in each changed package, then run its yarn format, yarn lint, yarn build, and yarn test. Finish with yarn clean-lage-cache then yarn lage buildci; run yarn lage test-links --verbose --grouped after markdown changes.
  • Add a patch changeset for each changed published package. Update the owning references/current-status.md rows (done, work in progress, unsupported) and affected README/AGENTS guidance in the same change.
  • Native, provider, or process-topology changes need matching-OS native contracts and the affected consumer lane. JavaScript tests and bundles do not qualify native behavior; hosted capability skips are not passes. Report each check as passed, failed, skipped, not run, or unsupported.

Evidence

  • Current state: the Storybook row of "Full-submission checklist" in packages/agentic/desktop-test/references/current-status.md.
  • Retired plan: driver-next.md at 0569e1b86, section 8 (F6).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions