diff --git a/change/@fluentui-react-native-menu-6957b6f8-6e59-4849-8351-0c3eb03d7f31.json b/change/@fluentui-react-native-menu-6957b6f8-6e59-4849-8351-0c3eb03d7f31.json new file mode 100644 index 00000000000..ba284778772 --- /dev/null +++ b/change/@fluentui-react-native-menu-6957b6f8-6e59-4849-8351-0c3eb03d7f31.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "address code review feedback", + "packageName": "@fluentui-react-native/menu", + "email": "jasonmo@microsoft.com", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-overflow-51310506-57cc-4495-9380-0006468d3968.json b/change/@fluentui-react-native-overflow-51310506-57cc-4495-9380-0006468d3968.json new file mode 100644 index 00000000000..58117c6d74d --- /dev/null +++ b/change/@fluentui-react-native-overflow-51310506-57cc-4495-9380-0006468d3968.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "address code review feedback", + "packageName": "@fluentui-react-native/overflow", + "email": "jasonmo@microsoft.com", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-native-tablist-338cba10-a27c-4d0a-9081-67f373417b33.json b/change/@fluentui-react-native-tablist-338cba10-a27c-4d0a-9081-67f373417b33.json new file mode 100644 index 00000000000..64a5bf134ef --- /dev/null +++ b/change/@fluentui-react-native-tablist-338cba10-a27c-4d0a-9081-67f373417b33.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "address code review feedback", + "packageName": "@fluentui-react-native/tablist", + "email": "jasonmo@microsoft.com", + "dependentChangeType": "none" +} diff --git a/packages/components/Menu/src/MenuTrigger/useMergeRefs.ts b/packages/components/Menu/src/MenuTrigger/useMergeRefs.ts index 96cf58ff215..e83e3be2873 100644 --- a/packages/components/Menu/src/MenuTrigger/useMergeRefs.ts +++ b/packages/components/Menu/src/MenuTrigger/useMergeRefs.ts @@ -34,7 +34,6 @@ export function useMergedRefs(...refs: (React.Ref | undefined)[]): RefObje } } }, - [...refs], ) as unknown as RefObjectFunction; diff --git a/packages/components/TabList/src/TabList/useTabList.ts b/packages/components/TabList/src/TabList/useTabList.ts index 5d6fa12d73d..f367425c47c 100644 --- a/packages/components/TabList/src/TabList/useTabList.ts +++ b/packages/components/TabList/src/TabList/useTabList.ts @@ -160,7 +160,6 @@ export const useTabList = (props: TabListProps): TabListInfo => { setFocusedTabRef(ref); } } - // Disable exhaustive-deps warning because this hook should only run once 'isSelectedTabDisabled' dependency changes. }, [isSelectedTabDisabled]); // win32 only prop used to implemement CTRL + TAB shortcut native to windows tab components diff --git a/packages/components/TabList/src/TabListAnimatedIndicator/useAnimatedIndicatorStyles.ts b/packages/components/TabList/src/TabListAnimatedIndicator/useAnimatedIndicatorStyles.ts index 7dd6f50ef20..53ec9fb61eb 100644 --- a/packages/components/TabList/src/TabListAnimatedIndicator/useAnimatedIndicatorStyles.ts +++ b/packages/components/TabList/src/TabListAnimatedIndicator/useAnimatedIndicatorStyles.ts @@ -16,7 +16,6 @@ export function useAnimatedIndicatorStyles(props: AnimatedIndicatorProps): Anima const indicatorScale = React.useRef(new Animated.Value(1)).current; // Save the initial selected layout, this shouldn't update after the first render. - const startingKey = React.useMemo(() => selectedKey, []); React.useEffect(() => { diff --git a/packages/experimental/Overflow/src/Overflow/useOverflow.ts b/packages/experimental/Overflow/src/Overflow/useOverflow.ts index 84fe4204c40..a8ca900307b 100644 --- a/packages/experimental/Overflow/src/Overflow/useOverflow.ts +++ b/packages/experimental/Overflow/src/Overflow/useOverflow.ts @@ -71,7 +71,6 @@ export function useOverflow(props: OverflowProps): OverflowInfo { overflowManager.removeItem(id); }, // overflowManager is not needed as a dependency, due to being attached to a ref - [overflowItemUpdateCallbacks], ); diff --git a/scripts/src/utils/env.ts b/scripts/src/utils/env.ts index 76b9a9a7923..ba93c25616e 100644 --- a/scripts/src/utils/env.ts +++ b/scripts/src/utils/env.ts @@ -1,5 +1,14 @@ +/** + * Lage doesn't support cleanly passing parameters to sub scripts, so this allows our scripts that + * support a "fix" mode to be toggled via an environment variable. This allows things like lint --fix or + * lint-package --fix to be run from the root level without having to have duplicate scripts entries for + * each package. + */ + +// env variable to use export const FIX_ENV_VAR = 'FURN_FIX_MODE'; +// standard helper function to check for fix mode export function isFixMode(fromParam?: boolean): boolean { return fromParam || Boolean(process.env[FIX_ENV_VAR]); }