Skip to content

Split legacy iOS/Android hosting out of FluentTester into legacy-mobile - #4396

Merged
Jason Morse (JasonVMo) merged 2 commits into
mainfrom
user/jasonvmo/split-mobile
Oct 27, 2026
Merged

Jason Morse (JasonVMo) merged 2 commits into
mainfrom
user/jasonvmo/split-mobile

Conversation

@JasonVMo

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Moves iOS and Android hosting out of FluentTester into a new private legacy-mobile app. This prepares the desktop FluentTester test passes to move from Appium to the desktop-test/desktop-driver harness. Mobile PR validation keeps the same build-only coverage.

  • apps/legacy-mobile (new, private): owns the iOS/Android React Native Test App host: app.json, entry points, Metro/Babel/TypeScript configuration, Android Gradle and iOS Podfile/lockfile, assets, and docs. App identity is unchanged (FluentTester app key, FluentTester.xcworkspace, ReactTestApp scheme).
  • apps/fluent-tester: now targets only macOS and Windows; its mobile configuration, dependencies, and bundle scripts are removed. It keeps @react-native-community/cli-platform-ios because react-native-macos platform discovery needs it.
  • .github/workflows/pr.yml: the Android and iOS jobs now use apps/legacy-mobile and keep their job names and coverage: Android bundles JavaScript; iOS bundles, installs pods, and builds the simulator app. No mobile UI tests are added.
  • apps/E2E: removes wdio.conf.android.js, wdio.conf.ios.js, the mobile scripts, and the direct mobile Appium driver dependencies. Mobile spec sources remain as dormant reference. appium.test.cjs checks that the mobile runners stay retired, that legacy-mobile has no Appium/WebdriverIO dependencies, and that Windows Appium discovery still works. Desktop Appium lanes are unchanged.
  • .yarnrc.yml / yarn.lock: removes the mobile Appium driver catalog entries and the unused WebDriverAgent package extension.
  • iOS app icon: React Native Test App's ios.icons option resolves the icon against app.json's file path instead of its directory, which made pod install warn that the icon file was invalid. It also writes resized icons outside the asset catalog. The ios.icons entry is removed; the icon is committed as assets/AppIcon.appiconset and the Podfile's post_install hook copies it into the generated asset catalog. No dependency patch is used.
  • Docs and configuration: updates the FluentTester, E2E, and component-generator READMEs, CONTRIBUTING.md, the legacy test apps agent reference, the VS Code launch configuration, and the root tsconfig.json references.
  • Changeset: patch for @fluentui-react-native/tester.

Verification

Run locally on macOS:

Command Result
yarn workspace @fluentui-react-native/e2e-testing test:appium Passed (5/5)
yarn workspace legacy-mobile build, yarn workspace @fluentui-react-native/tester build, yarn workspace @fluentui-react-native/e2e-testing build Passed
yarn workspace legacy-mobile bundle:android and bundle:ios Passed
yarn workspace @fluentui-react-native/tester bundle:macos and bundle:windows Passed
cd apps/legacy-mobile/ios && pod install Passed, with no icon-path warnings
CCACHE_DISABLE=1 ./.github/scripts/xcodebuild.mts apps/legacy-mobile/ios/FluentTester.xcworkspace iphonesimulator ReactTestApp build Passed; the app's Info.plist and Assets.car contain the custom AppIcon
yarn clean-lage-cache && yarn lage buildci Passed (176 tasks, 0 failed)
yarn change:check Passed (@fluentui-react-native/tester)

Not run: the Android Gradle build (the PR pipeline does not run it either), launching on a device, simulator, or emulator, mobile UI tests (none remain active), FluentTester macOS/Windows native builds, and Win32.

Before After
FluentTester hosts iOS, Android, macOS, and Windows; E2E has iOS/Android Appium configurations and driver dependencies. FluentTester hosts macOS and Windows; legacy-mobile hosts iOS and Android with no Appium or WebdriverIO dependencies.
pod install repeatedly warns that the configured iOS icon is not a valid file, and the app gets no custom icon. No icon warnings; the simulator app packages the custom AppIcon.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 64 (+2) 65 (+2) 50.63k (+687b) 50.55k (+687b)
components-catalog 214 (+55) 215 (+55) 205.49k (+50.22k) 205.41k (+50.22k)
design-theme-state 34 (+1) 35 (+1) 30.15k (+42b) 30.08k (+42b)
design-themed-root 38 (+1) 39 (+1) 32.12k (+42b) 32.04k (+42b)
design-color-lib 6 (+0) 6 (+0) 6.33k (+0b) 6.33k (+0b)
design-theme-state-legacy-source 35 (+1) 36 (+1) 31.81k (+42b) 31.73k (+42b)
design-legacy-theme-from-flex 58 (+1) 59 (+1) 97.77k (+42b) 97.63k (+42b)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

@JasonVMo
Jason Morse (JasonVMo) merged commit e8f017c into main Oct 27, 2026
18 checks passed
@JasonVMo
Jason Morse (JasonVMo) deleted the user/jasonvmo/split-mobile branch October 27, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants