Repository navigation
Split legacy iOS/Android hosting out of FluentTester into legacy-mobile - #4396
Merged
Merged
Conversation
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
5 of 10 tasks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jason Morse (JasonVMo)
force-pushed
the
user/jasonvmo/split-mobile
branch
from
October 27, 2026 02:20
b5f439b to
6c92fda
Compare
Vladimir Morozov (vmoroz)
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Moves iOS and Android hosting out of FluentTester into a new private
legacy-mobileapp. This prepares the desktop FluentTester test passes to move from Appium to thedesktop-test/desktop-driverharness. Mobile PR validation keeps the same build-only coverage.apps/legacy-mobile(new, private): owns the iOS/Android React Native Test App host:app.json, entry points, Metro/Babel/TypeScript configuration, Android Gradle and iOS Podfile/lockfile, assets, and docs. App identity is unchanged (FluentTesterapp key,FluentTester.xcworkspace,ReactTestAppscheme).apps/fluent-tester: now targets only macOS and Windows; its mobile configuration, dependencies, and bundle scripts are removed. It keeps@react-native-community/cli-platform-iosbecausereact-native-macosplatform discovery needs it..github/workflows/pr.yml: the Android and iOS jobs now useapps/legacy-mobileand keep their job names and coverage: Android bundles JavaScript; iOS bundles, installs pods, and builds the simulator app. No mobile UI tests are added.apps/E2E: removeswdio.conf.android.js,wdio.conf.ios.js, the mobile scripts, and the direct mobile Appium driver dependencies. Mobile spec sources remain as dormant reference.appium.test.cjschecks that the mobile runners stay retired, thatlegacy-mobilehas no Appium/WebdriverIO dependencies, and that Windows Appium discovery still works. Desktop Appium lanes are unchanged..yarnrc.yml/yarn.lock: removes the mobile Appium driver catalog entries and the unused WebDriverAgent package extension.ios.iconsoption resolves the icon againstapp.json's file path instead of its directory, which madepod installwarn that the icon file was invalid. It also writes resized icons outside the asset catalog. Theios.iconsentry is removed; the icon is committed asassets/AppIcon.appiconsetand the Podfile'spost_installhook copies it into the generated asset catalog. No dependency patch is used.CONTRIBUTING.md, the legacy test apps agent reference, the VS Code launch configuration, and the roottsconfig.jsonreferences.@fluentui-react-native/tester.Verification
Run locally on macOS:
yarn workspace @fluentui-react-native/e2e-testing test:appiumyarn workspace legacy-mobile build,yarn workspace @fluentui-react-native/tester build,yarn workspace @fluentui-react-native/e2e-testing buildyarn workspace legacy-mobile bundle:androidandbundle:iosyarn workspace @fluentui-react-native/tester bundle:macosandbundle:windowscd apps/legacy-mobile/ios && pod installCCACHE_DISABLE=1 ./.github/scripts/xcodebuild.mts apps/legacy-mobile/ios/FluentTester.xcworkspace iphonesimulator ReactTestApp buildInfo.plistandAssets.carcontain the customAppIconyarn clean-lage-cache && yarn lage buildciyarn change:check@fluentui-react-native/tester)Not run: the Android Gradle build (the PR pipeline does not run it either), launching on a device, simulator, or emulator, mobile UI tests (none remain active), FluentTester macOS/Windows native builds, and Win32.
legacy-mobilehosts iOS and Android with no Appium or WebdriverIO dependencies.pod installrepeatedly warns that the configured iOS icon is not a valid file, and the app gets no custom icon.AppIcon.Pull request checklist
This PR has considered (when applicable):