Skip to content

Run legacy desktop E2E through desktop-test from the app workspaces and remove Appium - #4397

Merged
Jason Morse (JasonVMo) merged 4 commits into
mainfrom
user/jasonvmo/remove-appium
Oct 27, 2026
Merged

Jason Morse (JasonVMo) merged 4 commits into
mainfrom
user/jasonvmo/remove-appium

Conversation

@JasonVMo

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Stacked on #4396. Review only the top three commits (9f5b7e836, 72f231797, 6bace0b74). This PR retargets to main after #4396 merges.

This PR moves the FluentTester (macOS, Windows) and Win32 legacy end-to-end suites from Appium to @fluentui-react-native/desktop-test, runs them from the app workspaces, and moves the repository to the latest stable WebdriverIO.

Related: #4345 (it deferred the legacy E2E migration).

App commands and CI

  • apps/fluent-tester: e2eprep:macos and e2eprep:windows build the driver helper, bundle, prepare, and build the app. e2etest:macos and e2etest:windows run the tests.
  • apps/win32: e2eprep:win32 builds the helper and bundle; e2etest:win32 runs the tests.
  • Each e2etest runs the shared legacy suite in apps/E2E through apps/E2E/desktop.config.mts.
  • .github/workflows/pr.yml: the macos, windows, and win32 jobs run those commands. They set up the desktop driver, upload desktop-test artifacts, and keep Windows crash dumps. Job IDs are unchanged.
  • Windows now builds the Fabric RN Test App (the old lane was Paper):
    • The build uses the app's windows script and pins one SDK across the solution: WindowsTargetPlatformVersion when it is set (10.0.26100.0 in CI, the only SDK on hosted Windows Server 2025), otherwise 10.0.22621.0.
    • apps/fluent-tester/scripts/register-windows-app.ps1 registers the Debug package.
    • The harness owns Metro on port 8081 and matches the FluentTester window title.

Dependencies

  • WebdriverIO ^10.1.0 and expect-webdriverio ^8.0.0. The expect-webdriverio 5.6.1 Yarn patch is removed.
  • Node engines are ^22.19.0 || ^24.0.0 || >=26.0.0, as WebdriverIO 10 requires.
  • Removed Appium and its drivers: catalog entries, package extensions, wdio.conf.*.js, appium.test.cjs, launchE2EWindows.ps1, Appium debugging images, and .gitignore entries. Also removed are eight root resolutions that only served the Appium dependency tree.
  • @wdio/logger is removed from four manifests. It existed only to satisfy the expect-webdriverio@5 peer requirement.

desktop-driver

  • I checked for workarounds that existed only because of the patched expect-webdriverio and found none; the patch only guarded a dual-load hasOwnProperty conflict. attachedWaitDefaults, the isDisplayed/isFocused overrides, the nativeElementId retry, and reporter attempt mapping handle WebdriverIO behavior that still exists in 10.1, so they stay.
  • Element command overwrites pass { attachToElement: true }, which WebdriverIO 10 requires.
  • Windows and Win32 snapshots expose UI Automation HelpText as helpText. An explicit empty string is supported, and absent help text stays unsupported. The field is additive, and the wire version is unchanged.

Legacy E2E suite (apps/E2E)

  • The shared beforeSession hook opts out of WebdriverIO 10 strict selectors because native test IDs resolve to several elements. Storybook story tests keep strict selectors.
  • Test fixes for the new harness:
    • HelpText maps to the native helpText.
    • Negative clicks on disabled controls use physical pointer actions.
    • The navigation safety check reads the native tree instead of using XPath.
    • Scroll visibility is clipped to the window client area.
    • The Win32 FocusZone suites have distinct describe names, as Jasmine 6 requires.
  • Docs rewritten: apps/E2E/README.md, the app READMEs, the desktop-test and desktop-driver references, and CONTRIBUTING.md.

Changesets: desktop-e2e-app-commands, wdio-10-desktop-testing, legacy-windows-desktop-qualification.

Verification

Command (where) Result
yarn clean-lage-cache && yarn lage buildci (repo root, at 6bace0b74) Passed: 176/176 tasks
yarn change:check (repo root, at 6bace0b74) Passed
yarn lage test-links (repo root) Passed: 89/89
yarn e2etest:macos (apps/fluent-tester, macOS Fabric, at 6bace0b74) Passed: 62/62, 0 skipped, 0 retries
yarn e2eprep:macos (apps/fluent-tester, macOS, before 72f231797, which does not change the macOS app) Passed; its build was used by the run above
yarn storybook smoke --macos --mode stories-and-tests (apps/storybook, Fabric, before 72f231797) Passed: 280/280, including 81 story WDIO callbacks on WebdriverIO 10
yarn e2etest:win32 (apps/win32, interactive Windows host) Passed: 201 tests in 40 files, 0 skipped, 0 retries
yarn e2etest:windows (apps/fluent-tester, interactive Windows host, SDK 10.0.22621.0) Passed: 39 tests in 10 files, 0 skipped, 0 retries
desktop-test --list for the legacy suite 31 macOS, 10 Windows, and 40 Win32 spec files

Not run:

  • The Windows lane with SDK 10.0.26100.0, the value CI uses. This PR's windows job is the first build with it. It also checks job duration against the 60-minute timeout now that React Native Windows builds from source.
  • Hosted runs of the three legacy jobs. Their input features stay enabled, unlike the Storybook jobs, so the first hosted runs qualify that.
  • macOS Paper, and the Paper, Windows, and Win32 Storybook lanes locally. The PR Storybook jobs cover those lanes.
Before After
Legacy desktop E2E ran through Appium from apps/E2E (e2eprep:*/e2etest:* there) with a patched expect-webdriverio 5.6.1 on WebdriverIO 9 Legacy desktop E2E runs through desktop-test from apps/fluent-tester and apps/win32 on WebdriverIO 10.1 and expect-webdriverio 8, with no patch and no Appium

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 64 (+0) 65 (+0) 50.63k (+0b) 50.55k (+0b)
components-catalog 214 (+0) 215 (+0) 205.49k (+0b) 205.41k (+0b)
design-theme-state 34 (+0) 35 (+0) 30.15k (+0b) 30.08k (+0b)
design-themed-root 38 (+0) 39 (+0) 32.12k (+0b) 32.04k (+0b)
design-color-lib 6 (+0) 6 (+0) 6.33k (+0b) 6.33k (+0b)
design-theme-state-legacy-source 35 (+0) 36 (+0) 31.81k (+0b) 31.73k (+0b)
design-legacy-theme-from-flex 58 (+0) 59 (+0) 97.77k (+0b) 97.63k (+0b)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

Base automatically changed from user/jasonvmo/split-mobile to main October 27, 2026 06:38
Hosted windows-latest (Windows Server 2025) ships only SDK 10.0.26100.0, so the
fixed 10.0.22621.0 pin would fail the PR Windows job. The build now uses
WindowsTargetPlatformVersion when it is set (the PR workflow sets 10.0.26100.0,
matching the previous lane) and keeps 10.0.22621.0 as the local default, still
pinning one SDK across the solution.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the upstream Windows SDK override, size the tester window for hosted desktops, avoid native clip-edge clicks, and use keyboard navigation when macOS physical clicks are disabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c786bea1-0895-43e7-85ea-ddfa98295f66
@JasonVMo
Jason Morse (JasonVMo) enabled stacked auto-merge (squash) October 27, 2026 06:49
@JasonVMo
Jason Morse (JasonVMo) merged commit fe236bf into main Oct 27, 2026
18 checks passed
@JasonVMo
Jason Morse (JasonVMo) deleted the user/jasonvmo/remove-appium branch October 27, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants