Repository navigation
Run legacy desktop E2E through desktop-test from the app workspaces and remove Appium - #4397
Merged
Merged
Conversation
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Jason Morse (JasonVMo)
force-pushed
the
user/jasonvmo/remove-appium
branch
from
October 27, 2026 02:20
6bace0b to
e7729c8
Compare
Vladimir Morozov (vmoroz)
approved these changes
Oct 27, 2026
Hosted windows-latest (Windows Server 2025) ships only SDK 10.0.26100.0, so the fixed 10.0.22621.0 pin would fail the PR Windows job. The build now uses WindowsTargetPlatformVersion when it is set (the PR workflow sets 10.0.26100.0, matching the previous lane) and keeps 10.0.22621.0 as the local default, still pinning one SDK across the solution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the upstream Windows SDK override, size the tester window for hosted desktops, avoid native clip-edge clicks, and use keyboard navigation when macOS physical clicks are disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c786bea1-0895-43e7-85ea-ddfa98295f66
Jason Morse (JasonVMo)
force-pushed
the
user/jasonvmo/remove-appium
branch
from
October 27, 2026 06:46
e6eea8c to
3140175
Compare
Jason Morse (JasonVMo)
enabled stacked auto-merge (squash)
October 27, 2026 06:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This PR moves the FluentTester (macOS, Windows) and Win32 legacy end-to-end suites from Appium to
@fluentui-react-native/desktop-test, runs them from the app workspaces, and moves the repository to the latest stable WebdriverIO.Related: #4345 (it deferred the legacy E2E migration).
App commands and CI
apps/fluent-tester:e2eprep:macosande2eprep:windowsbuild the driver helper, bundle, prepare, and build the app.e2etest:macosande2etest:windowsrun the tests.apps/win32:e2eprep:win32builds the helper and bundle;e2etest:win32runs the tests.e2etestruns the sharedlegacysuite inapps/E2Ethroughapps/E2E/desktop.config.mts..github/workflows/pr.yml: themacos,windows, andwin32jobs run those commands. They set up the desktop driver, upload desktop-test artifacts, and keep Windows crash dumps. Job IDs are unchanged.windowsscript and pins one SDK across the solution:WindowsTargetPlatformVersionwhen it is set (10.0.26100.0 in CI, the only SDK on hosted Windows Server 2025), otherwise 10.0.22621.0.apps/fluent-tester/scripts/register-windows-app.ps1registers the Debug package.FluentTesterwindow title.Dependencies
^10.1.0andexpect-webdriverio^8.0.0. Theexpect-webdriverio5.6.1 Yarn patch is removed.^22.19.0 || ^24.0.0 || >=26.0.0, as WebdriverIO 10 requires.wdio.conf.*.js,appium.test.cjs,launchE2EWindows.ps1, Appium debugging images, and.gitignoreentries. Also removed are eight root resolutions that only served the Appium dependency tree.@wdio/loggeris removed from four manifests. It existed only to satisfy theexpect-webdriverio@5peer requirement.desktop-driver
expect-webdriverioand found none; the patch only guarded a dual-loadhasOwnPropertyconflict.attachedWaitDefaults, theisDisplayed/isFocusedoverrides, thenativeElementIdretry, and reporter attempt mapping handle WebdriverIO behavior that still exists in 10.1, so they stay.{ attachToElement: true }, which WebdriverIO 10 requires.HelpTextashelpText. An explicit empty string is supported, and absent help text stays unsupported. The field is additive, and the wire version is unchanged.Legacy E2E suite (
apps/E2E)beforeSessionhook opts out of WebdriverIO 10 strict selectors because native test IDs resolve to several elements. Storybook story tests keep strict selectors.HelpTextmaps to the nativehelpText.describenames, as Jasmine 6 requires.apps/E2E/README.md, the app READMEs, the desktop-test and desktop-driver references, andCONTRIBUTING.md.Changesets:
desktop-e2e-app-commands,wdio-10-desktop-testing,legacy-windows-desktop-qualification.Verification
yarn clean-lage-cache && yarn lage buildci(repo root, at6bace0b74)yarn change:check(repo root, at6bace0b74)yarn lage test-links(repo root)yarn e2etest:macos(apps/fluent-tester, macOS Fabric, at6bace0b74)yarn e2eprep:macos(apps/fluent-tester, macOS, before72f231797, which does not change the macOS app)yarn storybook smoke --macos --mode stories-and-tests(apps/storybook, Fabric, before72f231797)yarn e2etest:win32(apps/win32, interactive Windows host)yarn e2etest:windows(apps/fluent-tester, interactive Windows host, SDK 10.0.22621.0)desktop-test --listfor thelegacysuiteNot run:
windowsjob is the first build with it. It also checks job duration against the 60-minute timeout now that React Native Windows builds from source.apps/E2E(e2eprep:*/e2etest:*there) with a patchedexpect-webdriverio5.6.1 on WebdriverIO 9desktop-testfromapps/fluent-testerandapps/win32on WebdriverIO 10.1 andexpect-webdriverio8, with no patch and no AppiumPull request checklist
This PR has considered (when applicable):