Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/desktop-e2e-app-commands.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@fluentui-react-native/tester": patch
---

FluentTester runs its macOS and Windows end-to-end tests through `desktop-test`: `yarn e2eprep:<platform>` prepares
the app and `yarn e2etest:<platform>` runs the `legacy` suite from `apps/E2E`. The Windows build also registers the
Debug package with `scripts/register-windows-app.ps1`. The Appium and WinAppDriver lanes are removed.
8 changes: 8 additions & 0 deletions .changeset/legacy-windows-desktop-qualification.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@fluentui-react-native/desktop-driver': patch
'@fluentui-react-native/tester': patch
---

Expose authoritative Windows accessibility help text for legacy desktop tests
and align the FluentTester Windows SDK and launch title across native dependencies
and the desktop harness.
11 changes: 11 additions & 0 deletions .changeset/wdio-10-desktop-testing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@fluentui-react-native/desktop-driver": patch
"@fluentui-react-native/desktop-test": patch
"@fluentui-react-native/storybook-desktop": patch
---

Move to WebdriverIO 10.1 and expect-webdriverio 8, replacing the patched expect-webdriverio 5.6.1. WebdriverIO 10
requires Node.js 22.19 or newer. Desktop Driver now passes the `{ attachToElement: true }` option object that
WebdriverIO 10 requires when it overwrites element commands. WebdriverIO 10 also makes selectors strict by default, so
a selector that matches several elements now throws; see the desktop-test WDIO suites reference for the opt-out. Storybook
Desktop no longer depends on `@wdio/logger`, which only satisfied the old expect-webdriverio peer requirement.
134 changes: 68 additions & 66 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,40 +150,33 @@ jobs:
- name: Build packages
run: yarn build

- name: Bundle macOS
run: |
set -eox pipefail
yarn bundle:macos
working-directory: apps/fluent-tester

- name: Pod install
run: |
set -eox pipefail
pod install --verbose
working-directory: apps/fluent-tester/macos

- name: Build macOS app
run: ./.github/scripts/xcodebuild.mts apps/fluent-tester/macos/FluentTester.xcworkspace macosx ReactTestApp build
env:
CCACHE_DISABLE: 1
# Hosted macOS clicks use accessibility actions, as in the Storybook job; keyboard and wheel stay enabled.
- name: Set up macOS Desktop Driver
id: desktop-driver
uses: ./.github/actions/setup-desktop-driver
with:
platform: macos
disabled-input-features: physicalClick

# Disable macOS E2E test to unblock 0.81 checkin
- name: Prepare E2E macOS tests
run: yarn e2eprep:macos
working-directory: apps/E2E
working-directory: apps/fluent-tester
env:
CCACHE_DISABLE: 1

- name: Run E2E macOS tests
run: yarn e2etest:macos
working-directory: apps/E2E
working-directory: apps/fluent-tester

- name: Upload E2E macOS artifacts
if: ${{ always() }}
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: E2E_macos_Dump
name: E2E_macos_fabric_${{ github.run_id }}_${{ github.run_attempt }}
path: |
apps/E2E/reports
apps/E2E/errorShots
apps/E2E/artifacts/desktop
apps/fluent-tester/artifacts/desktop
${{ steps.desktop-driver.outputs.doctor-path }}

macos-storybook:
name: macOS Storybook PR
Expand Down Expand Up @@ -348,50 +341,59 @@ jobs:
- name: Build packages
run: yarn build

- name: Bundle Windows
run: yarn bundle:windows
working-directory: apps/fluent-tester
# The legacy specs navigate with the keyboard and scroll with the wheel, so unlike the Storybook job
# every input feature stays enabled.
- name: Set up Windows Desktop Driver
id: desktop-driver
uses: ./.github/actions/setup-desktop-driver
with:
platform: windows

- name: Install WinAppDriver 1.1
- name: Install Windows App Runtime 1.8
shell: pwsh
run: |
Invoke-WebRequest https://github.com/microsoft/WinAppDriver/releases/download/v1.1/WindowsApplicationDriver.msi -OutFile $env:RUNNER_TEMP\WinAppDriver.msi
Start-Process msiexec -ArgumentList "/quiet","/x","{087BBF93-D9E3-4D27-BDBE-9C702E0066FC}" -Verb runAs -Wait
Start-Process msiexec -ArgumentList "/quiet","/i","$env:RUNNER_TEMP\WinAppDriver.msi" -Verb runAs -Wait
shell: powershell
$installer = Join-Path $env:RUNNER_TEMP 'WindowsAppRuntimeInstall-x64.exe'
Invoke-WebRequest 'https://aka.ms/windowsappsdk/1.8/1.8.260804001/windowsappruntimeinstall-x64.exe' -OutFile $installer
& $installer --quiet
if ($LASTEXITCODE -ne 0) {
throw "Windows App Runtime installer exited with code $LASTEXITCODE."
}

- name: Generate RNW app
run: yarn install-windows-test-app --use-nuget
working-directory: apps/fluent-tester
$runtime = Get-AppxPackage -Name 'Microsoft.WindowsAppRuntime.1.8'
if (-not $runtime) {
throw 'Microsoft.WindowsAppRuntime.1.8 was not registered for the runner user.'
}

# Register before launch so first-launch crashes are captured.
- name: Enable crash dumps
shell: pwsh
run: |
$dumps = Join-Path $env:RUNNER_TEMP 'crash-dumps'
New-Item -ItemType Directory -Force -Path $dumps | Out-Null
reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps\ReactApp.exe" /v DumpType /t REG_DWORD /d 2 /f
reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps\ReactApp.exe" /v DumpFolder /t REG_EXPAND_SZ /d "$dumps" /f

- name: Prepare E2E Windows tests
run: yarn e2eprep:windows
working-directory: apps/E2E

- name: Start packager
run: cmd /c "start /B cmd /c yarn start ^> packager.log 2^>^&1"
working-directory: apps/fluent-tester

# First build of RNW may fail with Cannot open include file: 'CppWinRTIncludes.h' error
# So we run the build command twice
- name: Build RNW app
run: yarn windows --arch x64 --logging --no-packager --no-launch --msbuildprops WindowsTargetPlatformVersion=10.0.26100.0; yarn windows --arch x64 --logging --no-packager --no-launch --msbuildprops WindowsTargetPlatformVersion=10.0.26100.0 || yarn windows --arch x64 --logging --no-packager --no-launch --singleproc --msbuildprops WindowsTargetPlatformVersion=10.0.26100.0
- name: Run E2E Windows tests
run: yarn e2etest:windows
working-directory: apps/fluent-tester

- name: Run E2E RNW tests
shell: powershell
run: |
.\launchE2EWindows.ps1 -enableDumpFiles
working-directory: apps/E2E

- name: Upload E2E Windows artifacts
if: ${{ always() }}
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: E2E_RNW_Dump
name: E2E_windows_fabric_${{ github.run_id }}_${{ github.run_attempt }}
path: |
apps/E2E/reports
apps/E2E/errorShots
apps/fluent-tester/packager.log
apps/E2E/artifacts/desktop
apps/fluent-tester/artifacts/desktop
${{ runner.temp }}/crash-dumps
${{ steps.desktop-driver.outputs.doctor-path }}
${{ steps.desktop-driver.outputs.cache-root }}/v1/artifacts/**/build.log
${{ steps.desktop-driver.outputs.cache-root }}/v1/diagnostics/**
if-no-files-found: warn

windows-storybook:
name: Windows Storybook PR
Expand Down Expand Up @@ -479,33 +481,33 @@ jobs:
- name: Build packages
run: yarn build

- name: Bundle Win32
run: yarn bundle
working-directory: apps/win32

- name: Install WinAppDriver 1.1
run: |
Invoke-WebRequest https://github.com/microsoft/WinAppDriver/releases/download/v1.1/WindowsApplicationDriver.msi -OutFile $env:RUNNER_TEMP\WinAppDriver.msi
Start-Process msiexec -ArgumentList "/quiet","/x","{087BBF93-D9E3-4D27-BDBE-9C702E0066FC}" -Verb runAs -Wait
Start-Process msiexec -ArgumentList "/quiet","/i","$env:RUNNER_TEMP\WinAppDriver.msi" -Verb runAs -Wait
shell: powershell
# Like the Windows job, this leaves every input feature enabled for the keyboard and wheel specs.
- name: Set up Win32 Desktop Driver
id: desktop-driver
uses: ./.github/actions/setup-desktop-driver
with:
platform: win32

- name: Prepare E2E Win32 tests
run: yarn e2eprep:win32
working-directory: apps/E2E
working-directory: apps/win32

- name: Run E2E Win32 tests
run: yarn e2etest:win32
working-directory: apps/E2E
working-directory: apps/win32

- name: Upload E2E Win32 artifacts
if: ${{ always() }}
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: E2E_win32_Dump
name: E2E_win32_paper_${{ github.run_id }}_${{ github.run_attempt }}
path: |
apps/E2E/reports
apps/E2E/errorShots
apps/E2E/artifacts/desktop
apps/win32/artifacts/desktop
${{ steps.desktop-driver.outputs.doctor-path }}
${{ steps.desktop-driver.outputs.cache-root }}/v1/artifacts/**/build.log
${{ steps.desktop-driver.outputs.cache-root }}/v1/diagnostics/**
if-no-files-found: warn

win32-storybook:
name: Win32 Storybook PR
Expand Down
8 changes: 1 addition & 7 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ npm-debug.log*
yarn-debug.log*
yarn-error.log*
**/reports/
**/errorShots/
**/allure-results/
**/allure-report/
**/artifacts/desktop/

# Runtime data
Expand Down Expand Up @@ -131,7 +128,4 @@ packages/**/windows/**/x64/[Rr]elease*/
.github/copilot/settings.local.json

# Ccache
.ccache

# Appium
**/.appium
.ccache
97 changes: 0 additions & 97 deletions .yarn/patches/expect-webdriverio-npm-5.6.1-69666d39e9.patch

This file was deleted.

Loading
Loading