Repository navigation
CI: require full Win32 Storybook accessibility and physical-input lanes - #4431
Open
srividyaramas wants to merge 9 commits into
Open
srividyaramas wants to merge 9 commits into
srividyaramas wants to merge 9 commits into
Conversation
Preserve the masked accessibility smoke run, select Checkbox click and Button keyboard/focus callbacks in a serial unmasked pass, and reject skipped or missing required results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Declare exact accessibility, physical, and shared callbacks; run independent required lanes and reject missing or non-qualifying native execution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
srividyaramas
changed the title
…reporters Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Consume canonical test reports, persist endpoint and renderer, and remount the complete Win32 preview so prior scroll position cannot obstruct physical input. Preserve chrome preferences and add focused regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Give the Win32 decorator a naturally sized scrollable canvas so oversized stories remain physically reachable. Preserve other platform previews and native readiness markers. Supply the required app manifest in the spawned-CLI report regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
The real ScrollView initialization exceeded the five-second default on cold local and hosted workers, while warm and isolated runs passed. Give only this JavaScript regression a bounded fifteen-second budget; retain every assertion and all native timeouts. The complete uncached runtime suite passes 21/21. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Keep endpoint-specific input metadata beside each named callback, discover lane selections statically, and retain only the exact app-owned quarantine. Preserve all 90 compiled callback bodies and existing platform policies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design
I've set up the Win32/Paper Storybook suite to run in two required CI lanes: accessibility and physical input.
input-tests.win32.jsonfrom the stories, so there is no separate test list to maintain. Missing classifications fail CI. After testing, I verify that every selected callback actually ran using fresh Win32/Paper results. Missing, failed, unsupported, stale, flaky, or incomplete execution fails the coverage gate.The Win32 preview resets between tests, and its scrollable canvas keeps long stories reachable without resetting the sidebar or addon preferences. macOS and Windows/Fabric keep their existing behavior.
This checks test execution, not component readiness or whether the tests fully cover the SPEC.
Coverage
The catalog covers 90 eligible Win32 callbacks: 38 selected for accessibility and 83 for physical input, including 31 that run in both.
The existing Button #4373 quarantine remains selected but unvalidated, not counted as a pass. No new quarantines are added.