Skip to content

Design: require a theme for Flex theme consumers #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jason Morse (JasonVMo) wants to merge 1 commit into from
Closed

Design: require a theme for Flex theme consumers #4433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/design-require-theme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
'@fluentui-react-native/design': minor
'@fluentui-react-native/components': minor
---

Flex theme consumers now require a theme. `useThemeState` and `useThemeAppearance` throw when no `ThemeProvider`,
`ThemedRoot`, or legacy `ThemeContext` provider is above the caller instead of falling back to a default theme state,
and the default theme state is removed. Render components inside a `ThemedRoot` or `ThemeProvider`.

Add the `@fluentui-react-native/design/testing/theme` entry point with `TestThemeProvider` and `createThemeWrapper` for
tests that render Flex consumers. It is separate from `design/testing`, which stays free of `react-native`.

A legacy `ThemeReference` paired with `useThemeState` no longer bundles the x3 defaults and interaction algorithm, and
a component bundle that does not render `ThemedRoot` is about 17 KB raw smaller.
Loading
Loading