Repository navigation
Design: isolate Flex palettes and resolve system-aware defaults - #4452
Merged
Merged
Conversation
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Ruriko Araki (rurikoaraki)
approved these changes
Nov 5, 2026
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
flexCoolThemeand keepflexWarmThemeindependent of the opposite palette.FlexThemeDescription.tokensto resolve a complete description from the appearance.flexThemeremains a reference base and switches palettes withappearance.colorTone.flexCoolThemefor the provider-free hook fallback and an outermostThemedRootwithout an explicit theme. Lazily sample the system light/dark appearance once for the hook fallback, sharing its state, appearance, and style registry.Verification
Passed in
packages/agentic/design:yarn formatyarn lintyarn buildyarn test— 537 tests and 34 snapshots.yarn check:mappingsyarn gen:flex-defaults --checkPassed at the repository root:
yarn change:checkyarn bundle-size— macOS and Windows consumer bundles; fixed themes exclude the opposite palette and the dynamic theme retains both.yarn clean-lage-cachefollowed byyarn lage buildci— all 176 tasks passed on committed HEAD.yarn markdown-link-check -c .github/markdown-link-check-config.json packages/agentic/design/README.md packages/agentic/design/references/theming.md packages/agentic/design/references/tokens.md packages/agentic/design/references/entry-points.md packages/agentic/design/references/contributing.mdNative runtime, screen-reader, and manual UI qualification were not run. No native implementation changed.
flexThemewas fixed to cool.flexThemeselects by resolved tone.Pull request checklist
This PR has considered (when applicable):