Repository navigation
Enforce application-neutral desktop package boundaries - #4454
Merged
Jason Morse (JasonVMo) merged 2 commits intoNov 6, 2026
Merged
Jason Morse (JasonVMo) merged 2 commits into
Jason Morse (JasonVMo) merged 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Khalef Hosany (Khalef1)
approved these changes
Nov 6, 2026
Preserve shared native service recovery and neutral helper resolution. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jason Morse (JasonVMo)
enabled auto-merge (squash)
November 6, 2026 07:50
Jason Morse (JasonVMo)
deleted the
jasonmo-microsoft-f7-driver-boundaries
branch
November 6, 2026 08:01
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
@fluentui-react-native/desktop-driver/nativeexport that maps directly to the helper implementation.Closes #4438.
Mainline integration: Normal-merged F1's mainline commit
cd0ede21489c9ab8cb76fea07c4dec2e9699389finto this branch at141efe47f1a14252ead90e4b405d5c132201abd6, the current validated PR head. Preserved the F1 recovery and F7 neutrality rows additively, moved the new shareddriverService.tshelper resolver to/native, retained the./driver-serviceexport, and extended the real standalone consumer to load it. No unmerged sibling branch was integrated.Verification
Fresh post-integration validation at
141efe47f1a14252ead90e4b405d5c132201abd6:yarn install --immutable(repository root) - passed, with existing peer warnings and no lockfile delta.yarn buildandyarn lint(each inpackages/agentic/desktop-test) - passed.yarn test packageBoundary contracts(inpackages/agentic/desktop-test) - passed, 30 tests.yarn test(inpackages/agentic/desktop-test) - passed, 45 tests.yarn test nativeExport recovery(inpackages/agentic/desktop-driver) - passed, 13 tests.yarn test(inpackages/agentic/desktop-driver-mcp) - passed, 20 tests.yarn oxfmt --check(repository root) - passed.yarn clean-lage-cache(repository root) - passed.yarn lage buildci(repository root, after cache clear) - passed, 178 success, 0 skipped, 0 failed.yarn lage test-links --verbose --grouped(repository root) - passed, 90 success, 0 skipped, 0 failed.Local HEAD, the existing fork branch, and the live PR head were verified equal after the normal push; the worktree is clean. Hosted CI for the new head was still in progress when this evidence was added; the local results above do not claim completed hosted qualification.
Historical pre-integration validation at
dea892201bc3a17b98f6e0b66bcd7e067ad88990(retained, not attributed to the new head):yarn workspace @fluentui-react-native/desktop-driver build— passedyarn workspace @fluentui-react-native/desktop-test build— passedyarn workspace @fluentui-react-native/desktop-driver-mcp build— passedyarn workspace @fluentui-react-native/desktop-driver test— passed (53 suites, 791 tests; 8 suites and 61 tests skipped)yarn workspace @fluentui-react-native/desktop-test test— passed (6 suites, 44 tests)yarn workspace @fluentui-react-native/desktop-driver-mcp test— passed (2 suites, 20 tests)yarn workspace @fluentui-react-native/desktop-driver format— passedyarn workspace @fluentui-react-native/desktop-test format— passedyarn workspace @fluentui-react-native/desktop-driver-mcp format— passedyarn workspace @fluentui-react-native/desktop-driver lint— passedyarn workspace @fluentui-react-native/desktop-test lint— passedyarn workspace @fluentui-react-native/desktop-driver-mcp lint— passedyarn oxfmt --check— passedyarn check-agent-instructions— passedyarn change:check— passedyarn clean-lage-cache && yarn lage buildci— passed (178 success, 0 skipped, 0 failed)yarn lage test-links --verbose --grouped— passed (90 success, 0 skipped, 0 failed)Native platform qualification was not run; this change adds a package export and import-boundary tests, not native implementation changes. No new live macOS, Windows Fabric, or Win32 Paper lane was run for the mainline integration.
/native; tests check declared dependencies and real imports against React, React Native, and Storybook, and load a standalone consumer. No visual UI change.Pull request checklist
This PR has considered (when applicable):