Skip to content

Enforce application-neutral desktop package boundaries - #4454

Merged
Jason Morse (JasonVMo) merged 2 commits into
microsoft:mainfrom
JasonVMo:jasonmo-microsoft-f7-driver-boundaries
Nov 6, 2026
Merged

Jason Morse (JasonVMo) merged 2 commits into
microsoft:mainfrom
JasonVMo:jasonmo-microsoft-f7-driver-boundaries

Conversation

@JasonVMo

@JasonVMo Jason Morse (JasonVMo) commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

  • Add a dedicated @fluentui-react-native/desktop-driver/native export that maps directly to the helper implementation.
  • Move desktop-driver-mcp helper resolution to the native subpath, avoiding the WebdriverIO-heavy package root.
  • Add dependency/import boundary checks, negative fixtures, and a standalone consumer for the desktop packages.
  • Update package documentation and add patch changesets for all three packages.

Closes #4438.

Mainline integration: Normal-merged F1's mainline commit cd0ede21489c9ab8cb76fea07c4dec2e9699389f into this branch at 141efe47f1a14252ead90e4b405d5c132201abd6, the current validated PR head. Preserved the F1 recovery and F7 neutrality rows additively, moved the new shared driverService.ts helper resolver to /native, retained the ./driver-service export, and extended the real standalone consumer to load it. No unmerged sibling branch was integrated.

Verification

Fresh post-integration validation at 141efe47f1a14252ead90e4b405d5c132201abd6:

  • yarn install --immutable (repository root) - passed, with existing peer warnings and no lockfile delta.
  • yarn build and yarn lint (each in packages/agentic/desktop-test) - passed.
  • yarn test packageBoundary contracts (in packages/agentic/desktop-test) - passed, 30 tests.
  • yarn test (in packages/agentic/desktop-test) - passed, 45 tests.
  • yarn test nativeExport recovery (in packages/agentic/desktop-driver) - passed, 13 tests.
  • yarn test (in packages/agentic/desktop-driver-mcp) - passed, 20 tests.
  • yarn oxfmt --check (repository root) - passed.
  • yarn clean-lage-cache (repository root) - passed.
  • yarn lage buildci (repository root, after cache clear) - passed, 178 success, 0 skipped, 0 failed.
  • yarn lage test-links --verbose --grouped (repository root) - passed, 90 success, 0 skipped, 0 failed.

Local HEAD, the existing fork branch, and the live PR head were verified equal after the normal push; the worktree is clean. Hosted CI for the new head was still in progress when this evidence was added; the local results above do not claim completed hosted qualification.

Historical pre-integration validation at dea892201bc3a17b98f6e0b66bcd7e067ad88990 (retained, not attributed to the new head):

  • yarn workspace @fluentui-react-native/desktop-driver build — passed
  • yarn workspace @fluentui-react-native/desktop-test build — passed
  • yarn workspace @fluentui-react-native/desktop-driver-mcp build — passed
  • yarn workspace @fluentui-react-native/desktop-driver test — passed (53 suites, 791 tests; 8 suites and 61 tests skipped)
  • yarn workspace @fluentui-react-native/desktop-test test — passed (6 suites, 44 tests)
  • yarn workspace @fluentui-react-native/desktop-driver-mcp test — passed (2 suites, 20 tests)
  • yarn workspace @fluentui-react-native/desktop-driver format — passed
  • yarn workspace @fluentui-react-native/desktop-test format — passed
  • yarn workspace @fluentui-react-native/desktop-driver-mcp format — passed
  • yarn workspace @fluentui-react-native/desktop-driver lint — passed
  • yarn workspace @fluentui-react-native/desktop-test lint — passed
  • yarn workspace @fluentui-react-native/desktop-driver-mcp lint — passed
  • yarn oxfmt --check — passed
  • yarn check-agent-instructions — passed
  • yarn change:check — passed
  • yarn clean-lage-cache && yarn lage buildci — passed (178 success, 0 skipped, 0 failed)
  • yarn lage test-links --verbose --grouped — passed (90 success, 0 skipped, 0 failed)

Native platform qualification was not run; this change adds a package export and import-boundary tests, not native implementation changes. No new live macOS, Windows Fabric, or Win32 Paper lane was run for the mainline integration.

Before After
MCP helper resolution imported through the desktop-driver root entry, which includes the WebdriverIO integration; package neutrality was not enforced by runtime import fixtures. MCP imports helper resolution from /native; tests check declared dependencies and real imports against React, React Native, and Storybook, and load a standalone consumer. No visual UI change.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 78 (+0) 79 (+0) 73.63k (+0b) 73.55k (+0b)
components-catalog 227 (+0) 228 (+0) 229.31k (+0b) 229.24k (+0b)
design-theme-state 47 (+0) 48 (+0) 53.27k (+0b) 53.20k (+0b)
design-themed-root 51 (+0) 52 (+0) 55.26k (+0b) 55.19k (+0b)
design-color-lib 6 (+0) 6 (+0) 6.27k (+0b) 6.27k (+0b)
design-theme-state-legacy-source 48 (+0) 49 (+0) 53.80k (+0b) 53.73k (+0b)
design-legacy-theme 42 (+0) 42 (+0) 39.11k (+0b) 42.91k (+0b)
design-legacy-theme-from-flex 54 (+0) 54 (+0) 59.87k (+0b) 63.69k (+0b)
design-fluent-light-theme 7 (+0) 7 (+0) 18.74k (+0b) 22.59k (+0b)
design-fluent-theme 35 (+0) 35 (+0) 27.46k (+0b) 31.25k (+0b)
design-fluent-hc-theme 32 (+0) 32 (+0) 27.34k (+0b) 31.13k (+0b)
design-flex-theme 33 (+0) 33 (+0) 23.37k (+0b) 23.36k (+0b)
design-flex-warm-theme 33 (+0) 33 (+0) 23.43k (+0b) 23.42k (+0b)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

Preserve shared native service recovery and neutral helper resolution.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infrastructure: Guard neutral desktop package dependency and import boundaries

2 participants