Repository navigation
Unify desktop driver-service composition and wire durable recovery - #4455
Merged
Jason Morse (JasonVMo) merged 1 commit intoNov 6, 2026
Merged
Conversation
Use one harness factory for generic and Storybook native services, preserve uncertain mutations across restart, and fail closed for corrupt sibling records. Refs #4436. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Khalef Hosany (Khalef1)
approved these changes
Nov 6, 2026
Jason Morse (JasonVMo)
deleted the
jasonmo-microsoft-f1-service-recovery
branch
November 6, 2026 07:14
This was referenced Nov 6, 2026
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Platform impact is not platform qualification; see the gaps below.
Description of changes
desktop-test/driver-servicecomposition root for native helper policy, recovery, authority, descriptor lifetime, and settled shutdown./serversurface and preserve the supervised channel child.Relates to #4436. This is intentionally a non-closing reference: implementation is complete, but live Storybook/Paper, physical-input, and Windows/Win32 qualification remain outstanding.
Integration notes: F7 adds the driver
/nativesurface and should migrate the newdriverService.tsnative imports to it. F8 adds a separate desktop-test export and status row; preserve both tracks' export entries and status changes additively. No cross-branch integration is included here.Verification
Evidence is for unchanged head
de16d0cfea1898776ba3341b8fb6cd98fc902aaf.yarn oxfmt --checkyarn clean-lage-cache && yarn lage buildciyarn lage test-links --verbose --groupedyarn workspace @fluentui-react-native/desktop-driver test recoveryFURN_NATIVE_DRIVER_TEST=1 yarn workspace @fluentui-react-native/desktop-driver test --runInBand applicationIncarnation.contract serviceIdentity.contractyarn workspace @fluentui-react-native/storybook-desktop test wdioRunneryarn change:checkA real macOS native shared-factory smoke also passed for prebuilt helper resolution, private durable recovery, exact-incarnation fencing, verified descriptor publication/withdrawal, corrupt-sibling restart fencing, and settled shutdown. Its temporary private storage was removed. The first standalone full Storybook suite attempt timed out in
wdioRunner; the isolated rerun passed and the clean-cache aggregate subsequently passed the package suite.Remaining platform qualification:
Pull request checklist
This PR has considered (when applicable):
Accessibility and localization checklist items are not applicable to this service-composition change; physical-input qualification remains explicitly unrun.