Skip to content

Unify desktop driver-service composition and wire durable recovery - #4455

Merged
Jason Morse (JasonVMo) merged 1 commit into
mainfrom
jasonmo-microsoft-f1-service-recovery
Nov 6, 2026
Merged

Jason Morse (JasonVMo) merged 1 commit into
mainfrom
jasonmo-microsoft-f1-service-recovery

Conversation

@JasonVMo

@JasonVMo Jason Morse (JasonVMo) commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Platform impact is not platform qualification; see the gaps below.

Description of changes

  • Route the generic supervisor and supervised Storybook channel child through one real desktop-test/driver-service composition root for native helper policy, recovery, authority, descriptor lifetime, and settled shutdown.
  • Persist settlement state under a private, stable target namespace; fail closed when either sibling journal record is corrupt, without trusting application identity.
  • Keep recovery contracts on the existing driver /server surface and preserve the supervised channel child.

Relates to #4436. This is intentionally a non-closing reference: implementation is complete, but live Storybook/Paper, physical-input, and Windows/Win32 qualification remain outstanding.

Integration notes: F7 adds the driver /native surface and should migrate the new driverService.ts native imports to it. F8 adds a separate desktop-test export and status row; preserve both tracks' export entries and status changes additively. No cross-branch integration is included here.

Verification

Evidence is for unchanged head de16d0cfea1898776ba3341b8fb6cd98fc902aaf.

Command Result
yarn oxfmt --check Passed.
yarn clean-lage-cache && yarn lage buildci Passed: 178 tasks, 0 failed.
yarn lage test-links --verbose --grouped Passed: 90 tasks, 0 failed.
yarn workspace @fluentui-react-native/desktop-driver test recovery Passed: 12 tests.
FURN_NATIVE_DRIVER_TEST=1 yarn workspace @fluentui-react-native/desktop-driver test --runInBand applicationIncarnation.contract serviceIdentity.contract Passed: 17 macOS native contract tests; 14 Windows tests skipped on macOS.
yarn workspace @fluentui-react-native/storybook-desktop test wdioRunner Passed: isolated timeout-prone contract.
yarn change:check Passed after commit.

A real macOS native shared-factory smoke also passed for prebuilt helper resolution, private durable recovery, exact-incarnation fencing, verified descriptor publication/withdrawal, corrupt-sibling restart fencing, and settled shutdown. Its temporary private storage was removed. The first standalone full Storybook suite attempt timed out in wdioRunner; the isolated rerun passed and the clean-cache aggregate subsequently passed the package suite.

Remaining platform qualification:

  • Not run: live Storybook app/Paper renderer restart lane or physical-input qualification.
  • Not run: Windows/Win32 native or consumer lanes. The Windows tests skipped on this macOS host.
Before After
Generic and Storybook native service paths construct services separately and omit durable settlement recovery; restarting can forget uncertain effects. Both paths use the shared factory, persist uncertainty across restart, require exact application-exit evidence, and withdraw descriptors before settled shutdown. Corrupt sibling records cannot conceal uncertainty.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

Accessibility and localization checklist items are not applicable to this service-composition change; physical-input qualification remains explicitly unrun.

Use one harness factory for generic and Storybook native services, preserve uncertain mutations across restart, and fail closed for corrupt sibling records. Refs #4436.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 78 (+0) 79 (+0) 73.63k (+0b) 73.55k (+0b)
components-catalog 227 (+0) 228 (+0) 229.31k (+0b) 229.24k (+0b)
design-theme-state 47 (+0) 48 (+0) 53.27k (+0b) 53.20k (+0b)
design-themed-root 51 (+0) 52 (+0) 55.26k (+0b) 55.19k (+0b)
design-color-lib 6 (+0) 6 (+0) 6.27k (+0b) 6.27k (+0b)
design-theme-state-legacy-source 48 (+0) 49 (+0) 53.80k (+0b) 53.73k (+0b)
design-legacy-theme 42 (+0) 42 (+0) 39.11k (+0b) 42.91k (+0b)
design-legacy-theme-from-flex 54 (+0) 54 (+0) 59.87k (+0b) 63.69k (+0b)
design-fluent-light-theme 7 (+0) 7 (+0) 18.74k (+0b) 22.59k (+0b)
design-fluent-theme 35 (+0) 35 (+0) 27.46k (+0b) 31.25k (+0b)
design-fluent-hc-theme 32 (+0) 32 (+0) 27.34k (+0b) 31.13k (+0b)
design-flex-theme 33 (+0) 33 (+0) 23.37k (+0b) 23.36k (+0b)
design-flex-warm-theme 33 (+0) 33 (+0) 23.43k (+0b) 23.42k (+0b)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants