Repository navigation
Add bounded authorized persisted desktop run queries - #4457
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Khalef Hosany (Khalef1)
approved these changes
Nov 6, 2026
…run-queries # Conflicts: # packages/agentic/desktop-test/references/current-status.md
Preserve F7 native boundaries alongside F8 persisted query status.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jason Morse (JasonVMo)
enabled auto-merge (squash)
November 6, 2026 08:10
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Implements F8 (#4439) with collector-authoritative persisted run/status/artifact queries under
desktop-test/src/reporting/and an explicit./reporting/run-queriespackage export. Adds bounded pages and text, explicit omission counts, opaque artifact IDs and snapshot-bound cursors, expiring/revocable harness-local read grants, and read-time redaction/retention with fail-closed storage validation.Collector snapshots now persist active state and use additive optional terminal metadata. Missing legacy terminal evidence remains incomplete; active, unfinished, and required all-skipped runs are not projected as success. Reader reconnect/recreation does not restart execution. Includes API/reporting documentation, current-status updates, tests, and a patch changeset. No lifecycle, native, Storybook, driver, or management-MCP surface was added by F8.
Mainline integration: Normal merge
479b9e0619f6ce6b7016aa8f68e97370335c07b1incorporates F7 from main0cfecf0b3a8d135c7cd7f5f6abc0400a9f00a3eb, following the earlier F1 integration at474b4a6ce69f07f9a307e414bb0c4193d49f4892. The sole conflict,desktop-test/references/current-status.md, was resolved additively: F7 neutrality/standalone-consumer evidence, F1 composition/recovery rows, F8 persisted-query completion, and separate management/control work remain represented. Driver./native, harness./driver-service, and./reporting/run-queriesexports remain present; F1's shared service uses F7's native subpath. No unmerged sibling branch was integrated.Closes #4439.
Verification
Post-F7 validation at
479b9e0619f6ce6b7016aa8f68e97370335c07b1:yarn install --immutable— passed with existing peer warnings and no lockfile change.cd packages/agentic/desktop-test && yarn build— passed.cd packages/agentic/desktop-test && yarn test runQueries contracts— passed, 2 suites and 56 tests.cd packages/agentic/desktop-driver && yarn test recovery— passed, 1 suite and 12 tests.yarn clean-lage-cache && yarn lage buildci && yarn lage test-links --verbose --grouped— cache clear passed; buildci failed with 141 successful tasks and 1 failure becauseprivateStorage.test.tsexceeded its 10000 ms deadline. Links were not run in this attempt.yarn --cwd packages/agentic/desktop-driver test privateStorage— passed, 62 tests passed and 10 skipped; 2 suites passed and 1 skipped.yarn lage buildci && yarn lage test-links --verbose --grouped— passed; buildci executed 44 successful tasks and reused 134 cached tasks, with 0 failures; links completed 90 successful tasks with 0 skipped/failed.yarn lage buildci --no-cache— passed, all 178 tasks successful, 0 skipped/failed.The coordinator independently read the retained aggregate failure/retry/uncached logs and verified a clean worktree, F7 mainline ancestry, local/remote/PR head equality, and GitHub
mergeable: trueafter the normal push. Focused results and immutable-install status above are reported by the implementation owner. Both the private-storage test and implementation are unchanged from the preceding F8 head; the timeout cause remains unconfirmed, and a retry pass is not proof of a baseline defect or a fix. Fresh hosted PR validation was still in progress when this evidence was captured.Historical pre-integration validation at
aa868544bc9b67b3f4c12dfb78ed5aa5d62542d8(not fresh-head results):yarn --cwd packages/agentic/desktop-test format— passed.yarn --cwd packages/agentic/desktop-test lint— passed.yarn --cwd packages/agentic/desktop-test build— passed.yarn --cwd packages/agentic/desktop-test test— passed, 6 suites and 70 tests.yarn change:check— passed.yarn check-agent-instructions— passed.yarn oxfmt --check— passed.git diff --check— passed.yarn clean-lage-cache && yarn lage buildci— passed, 178 successful tasks and 0 failed/skipped/aborted.yarn lage test-links --verbose --grouped— passed, 90 successful tasks and 0 failed/skipped/aborted.@fluentui-react-native/desktop-test/reporting/run-queriesimport check — passed.Native/Storybook/physical-input qualification and Windows/Win32 execution were not run; this change does not modify native or platform behavior, and JavaScript checks do not qualify native behavior. No Storybook app or desktop-driver app/service was launched for post-main validation. The privilege-dependent Windows file-symlink case is explicitly skipped on Windows. One early package test run encountered the existing 5-second owned-service fixture deadline; isolated contract and subsequent full-suite runs passed. Its cause is unconfirmed, so it is disclosed as an unattributed transient timing failure rather than a proven baseline defect.
Pull request checklist
This PR has considered (when applicable):