Skip to content

Qualify Windows desktop-driver ownership and physical input - #4469

Merged
Jason Morse (JasonVMo) merged 2 commits into
mainfrom
user/jasonvmo/windows-driver-followup
Nov 9, 2026
Merged

Jason Morse (JasonVMo) merged 2 commits into
mainfrom
user/jasonvmo/windows-driver-followup

Conversation

@JasonVMo

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

  • Contain unpackaged Windows launches in a helper-owned, kill-on-close Job Object; report packaged launches as uncontained and attachments as external.
  • Fail closed when attach identity cannot be verified, preserve handle ownership across failed lease registration, and improve foreground-activation diagnostics.
  • Record connected Windows Fabric and Win32 Paper qualification without erasing earlier failures or treating unsupported/partial cases as passes.

Relates to #4435, #4441, #4447, and #4348; packaged-survivor claim accounting remains with #4448.

Verification

  • $env:FURN_NATIVE_DRIVER_TEST='1'; yarn test --runInBand in desktop-driver — passed 909; skipped 31 (65 suites passed, two skipped). The exclusive claim was released.
  • $env:FURN_NATIVE_DRIVER_TEST='1'; yarn test win32Fixture --runInBand — passed 11; retained elements 20 at cycle 100 and 23 at cycle 500.
  • $env:FURN_NATIVE_DRIVER_TEST='1'; yarn test nativeDriver --runInBand — passed six; skipped two.
  • In apps/storybook, $env:STORYBOOK_SMOKE_STORY='components-checkbox--default'; yarn storybook smoke --windows --mode stories-and-tests --input physical --reporter json — 203 passed; two physical-click receipts.
  • $env:STORYBOOK_SMOKE_STORY='components-checkbox--default'; yarn storybook smoke --win32 --mode stories-and-tests --input physical --reporter json — 177 passed; two physical-click receipts.
  • $env:STORYBOOK_SMOKE_STORY='native-callout--default'; yarn storybook smoke --windows --mode stories-and-tests --input physical --reporter json — 203 passed; three physical-click receipts.
  • $env:STORYBOOK_SMOKE_STORY='native-callout--default'; yarn storybook smoke --win32 --mode stories-and-tests --input physical --reporter json — 177 passed; three physical-click receipts. All four smokes had zero failures, skips, unsupported cases, or retries; totals include catalog navigation and one authored case.
  • Real MCP SDK stdio clients used the default descriptor against each endpoint: two applied physical checkbox clicks and hash-verified target PNG capture passed on each. Manual operations are not selected suite tests.
  • Generic Win32 fixture: exact main/secondary dialog switching and minimized-window capture refusal passed; explicit restore produced a valid PNG.
  • yarn build, yarn lint, and yarn format --check passed in desktop-driver, desktop-driver-mcp, desktop-test, and storybook-desktop. yarn test --runInBand passed 26 in MCP, 200 with four skipped in desktop-test, and 320 in storybook-desktop.
  • yarn change:check, yarn check-agent-instructions, direct link checks on the three status files, and git diff --check passed.
  • yarn clean-lage-cache followed by yarn lage buildci — passed on the second plain retry (nine executed, 169 cached, no failed/pending/aborted tasks). The first attempt failed formatting on an unrelated untracked report; an exact temporary ignore excluded only that file and was removed afterward. The first retry had three Storybook failures under aggregate load (a child-process timeout, readiness during stop, and a worker-test timeout); the same package suite passed serially. The unrelated report was untouched.

Remaining limits: Win32 fresh-preview fencing and separately registered Storybook secondary windows remain partial; the serve --agent interrupt can leave its CLI idle. The Win32 app window closed but its REX process required an identity-verified stop, so the two app-run reports failed rather than proving graceful cleanup. Windows doctor --permissions is unsupported. DPI changes and physical Ctrl+C were not exercised.

Before After
Unpackaged launched descendants lacked helper-lifetime containment; foreground failures had limited diagnostics. Unpackaged launches are job-contained; activation failures report the foreground holder and cause. Connected physical input and capture are qualified only for the recorded bounded cases.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 19ee4435-64e4-4799-b8fc-f3b7742f2c92
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 19ee4435-64e4-4799-b8fc-f3b7742f2c92
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 79 (+1) 80 (+1) 72.78k (-842b) 72.71k (-842b)
components-catalog 228 (+1) 229 (+1) 228.46k (-855b) 228.38k (-855b)
design-themed-root 55 (+4) 56 (+4) 56.26k (+998b) 56.18k (+998b)
design-color-lib 6 (+0) 6 (+0) 6.27k (+0b) 6.27k (+0b)
design-theme-state-legacy-source 49 (+1) 50 (+1) 52.96k (-841b) 52.89k (-841b)
design-legacy-theme 42 (+0) 42 (+0) 39.11k (+0b) 42.91k (+0b)
design-legacy-theme-from-flex 58 (+4) 58 (+4) 60.70k (+824b) 64.51k (+822b)
design-fluent-light-theme 7 (+0) 7 (+0) 18.74k (+0b) 22.59k (+0b)
design-fluent-theme 35 (+0) 35 (+0) 27.46k (+4b) 31.25k (-1b)
design-fluent-hc-theme 32 (+0) 32 (+0) 27.34k (+0b) 31.13k (+0b)
design-flex-theme 29 (-4) 29 (-4) 14.30k (-9.07k) 14.29k (-9.07k)
design-flex-cool-theme 26 (New) 26 (New) 12.51k (New) 12.50k (New)
design-flex-warm-theme 26 (-7) 26 (-7) 12.28k (-11.15k) 12.27k (-11.15k)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants