Repository navigation
Expand agentic component unit and native Storybook tests - #4475
Conversation
Review all 29 agentic controls and add 62 unit cases plus 25 capability-described native Storybook cases. Register additional stories for strict checking; preserve legacy tests, snapshots, app exclusions and product behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
First native results at 4e703a1The Win32 jobs successfully built the packages, bundled the stories and started the actual host. They found two failures that the mocked unit tests could not establish.
Tag: Checkbox: the new keyboard traversal/toggle and stale-key-up cancellation cases passed. The held-key case toggled correctly but reported zero press-release callbacks where the fixture expected one. The native fallback and callback contract are being checked before changing that expectation. These are not all-platform passes. The PR remains a draft; other platform jobs are still running. |
Completed CI at 4e703a1Run 42732166279 has finished. JS/build/package checks passed, including Android, iOS, macOS, Windows and Win32 builds. The incomplete local dependency setup did not prevent the clean hosted builds. All five native Storybook jobs failed an assertion:
Counts are from the authoritative test runs, not successful helper-preparation runs. They include navigation and callbacks. Unsupported and unfinished work are not passes. Win32 physical also has one quarantined case; each macOS run has one declared unsupported case within its 16 unsupported results. Platform/input exclusions remain separate from these counts. The Tag failure is supported by captured native state: a visible, enabled button received an accessibility action without reporting activation. Divider's contract explicitly requires separator semantics and its implementation requests that role. The captured nodes match the intended ID/name, and normalization alone does not explain the three observed roles. This is a native projection gap, not a safe test-only correction. The raw macOS AXRole is not retained in the artifacts, so the precise provider boundary remains unlocalized. For Checkbox, the native fallback code suggests a possible explanation, but neither a recorded native key code nor an explicit contract exception supports allowing missing callbacks. An exploratory relaxation was rejected and restored locally; no weaker assertion was committed or pushed. The PR remains draft. The meaningful failures are retained; no physical-click substitution, synthetic fixture activation, invented unsupported marker or timeout increase was used to make them pass. These results do not establish readiness for all 29 controls. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Preserve trigger callbacks and controlled state, reserve grouped Win32 navigation keys, and connect enabled macOS Fabric AXPress to the registered native tap. Add focused regressions including disabled native action availability, preserving every existing dependency patch and test assertion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Give Tag focus-entry editors visible dimensions and keep ProgressBar's native geometry checks inside a sized, restored window. Preserve the original native assertions and record ordered Menu callbacks for the Windows closing trace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Jason Morse (JasonVMo)
left a comment
There was a problem hiding this comment.
Let me know when this is ready to go and I can sign off. The change looks good.
Preserve the existing button activation contract on macOS and Windows Fabric, with focused cross-desktop regression coverage. Native qualification remains pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Keep the existing second-Invoke closing assertion and public Menu pipeline unchanged while exposing the native dismissal reason in the bounded story journal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Set aside the new second-Invoke Menu case as requested, preserving its source and failure evidence outside the PR. Remove its diagnostic-only story assembly. Keep native Text width/height requirements while measuring macOS Text layout separately from AX projection. Compare image Icon dimensions with an equivalent native Image rather than treating Image and View AX frames as identical. Native macOS qualification is pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Keep the other Popover tests unchanged. Investigate the repeated-activation case together with the deferred Menu case in a separate PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
|
Jason Morse (@JasonVMo) - Thanks! This is ready for your review, and all checks have passed. I’ve deferred two new Menu and Popover accessibility tests to a separate PR. They exposed a close/reopen issue on Windows Fabric: activating an already-open trigger leaves the popup open instead of closing it. I’m investigating whether both share the same underlying cause. |
New tests
I went through the existing tests for all 29 agentic components and primitives and added tests for the gaps I found. This adds unit tests and 24 native Storybook tests. No tests were added for the older components or primitives.
The new tests cover:
I also added eight more story files to the TypeScript checks.
Validation completed