Repository navigation
Tighten Storybook manifest provenance and credential isolation - #4490
Merged
Jason Morse (JasonVMo) merged 11 commits intoNov 12, 2026
Merged
Conversation
Keep bridge and attachment credentials in OS-private records, validate centralized generated contracts, and pin the spawning child's helper to the independent parent handoff. Load runtime identity from a private data-only module. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Prepare the Storybook-owned call site for F10-M's native process identity verification without relocating channel or lease ownership. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept the extractor's declared/derived inputSource metadata while keeping authored case options strict. Cover realistic resolved descriptors and reject unsupported metadata; this fixes the consumer smoke's publication failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document portable and signed-native contract coverage, successful Fabric/Paper preparation, explicit Accessibility-blocked consumer outcomes, cleanup, final aggregate validation, and Windows CI sufficiency without claiming unrun native passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Route Windows smoke lease publication and cleanup through verified private storage, use the shared v3 control schema, and resolve generated directory aliases before creating private records. Cover receipt fencing, stock macOS paths, and symlink replacement; keep Windows qualification explicitly pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace superseded local temporary-directory qualification with default-TMPDIR package and aggregate evidence. Keep macOS consumer permission blocks and unobserved Windows/Win32 coverage explicit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Forward injected storage through the CLI factory and select host adapters explicitly. Derive protected Windows namespaces from the helper-selected per-user root, preserve Metro access outside the workspace, and report bounded refusal reasons without weakening native ACL checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Record default-TMPDIR package results, the locked 178-task aggregate, and the unconfirmed Windows refusal and timeout diagnoses. Keep native Windows qualification explicitly pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 of 10 tasks
Use a pinned-buffer transformer on the workspace stub for Windows and Win32 while preserving protected per-user storage and macOS resolution. Normalize Windows path identities and cover cross-drive, cache, delegation, and tamper cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jason Morse (JasonVMo)
marked this pull request as ready for review
November 12, 2026 05:47
5 of 10 tasks
Vladimir Morozov (vmoroz)
approved these changes
Nov 12, 2026
Jason Morse (JasonVMo)
deleted the
user/jasonvmo/desktop-manifest-trust
branch
November 12, 2026 22:02
This was referenced Nov 12, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Part of #4445, under #4435.
/varaliases work while subsequent ancestor replacement still fails closed with an actionable diagnostic.Verification
Validation used the default macOS TMPDIR without an override. Initial CI run
43145388693exposed dropped CLI fixture injection on Linux and unsafe-storage refusal in both Win32 smoke lanes. Run43150784347onca27c1b0bconfirms those fixes: JS PR, all macOS lanes, Windows/Win32 PR, and Windows native-helper setup passed; all three Storybook Windows lanes opened the protected per-user namespace.Those three lanes then failed bundling because Metro's file map recombined a
C:private source relative to aD:workspace intoD:\C:\.... The new transformer keeps that private source outside the file map. Regression fixtures exercisepath.win32cross-drive and case semantics, digest tampering, nonce cache invalidation, and unchanged delegation. Supplemental controlled fixtures passed the actual consumer worker/Babel/minifier and full minifiedmetro.runBuildfor both Windows targets, explicitly excluding the private source from the file map. These JavaScript results are not native Windows qualification.The prior setup build/handshake/UIA timeouts did not recur. This diff changes none of those native paths; the subsequent passing setup supports runner flakiness rather than a product timeout change.
The following exact commands were run from the repository root:
cd packages/agentic/desktop-driver && yarn format && yarn lint && yarn build && TF_BUILD=1 yarn testcd packages/agentic/storybook-desktop && yarn format && yarn lint && yarn build && TF_BUILD=1 yarn testcd packages/agentic/storybook-desktop-runtime && yarn format && yarn lint && yarn build && TF_BUILD=1 yarn testTF_BUILD=1 yarn workspace @fluentui-react-native/storybook-desktop-runtime test metroyarn workspace @fluentui-react-native/desktop-test formatyarn lage test-links --verbose --groupedyarn clean-lage-cache;TF_BUILD=1 yarn lage buildci --concurrency 4yarn lint-repo;yarn check-agent-instructions;yarn change:check;git diff --checkParseFilefor both smoke scriptspwshis not installedCross-volume fix and aggregate-qualified source:
e760a36de. Local evidence:apps/storybook/artifacts/f6/crossdrive-*.log.TF_BUILD=1selects the existing in-band Jest mode; it does not disable agentic tests. Both clean-cache and aggregate commands held the shared native lock.Earlier native qualification, before review fixes: the locked
FURN_NATIVE_DRIVER_TEST=1 yarn workspace @fluentui-react-native/desktop-driver test --runInBandpassed 1,240 tests with 47 platform/capability skips. The stable-signed helper doctor was ready but reported Accessibility/PostEvent unavailable. The following root commands passed under the shared lock; prep selected the already installed Ruby JSON 2.18 through a worktree-local preload. No shared tools or privacy settings changed.yarn workspace @fluentui-react-native/agentic-components-storybook storybook build-driver --macos— passed.yarn workspace @fluentui-react-native/agentic-components-storybook desktop-driver doctor --platform macos --permissions— passed (ready, with the permission limitations above).yarn workspace @fluentui-react-native/agentic-components-storybook storybook bundle --macos— passed.yarn workspace @fluentui-react-native/agentic-components-storybook storybook bundle --macos --paper— passed.yarn workspace @fluentui-react-native/agentic-components-storybook storybook prep --macos— passed after selecting installed JSON 2.18; initial JSON 3.1 selection failed on missingJSON.fast_generate.yarn workspace @fluentui-react-native/agentic-components-storybook storybook prep --macos --paper— passed.The following exact consumer commands, from the repository root, are failed / Accessibility-blocked, not passes:
yarn workspace @fluentui-react-native/agentic-components-storybook storybook smoke --macos --mode stories-and-tests --input accessible --reporter jsonyarn workspace @fluentui-react-native/agentic-components-storybook storybook smoke --macos --paper --mode stories-and-tests --input accessible --reporter jsonBoth built/launched the app and reached bridge epoch recording, then failed on Accessibility
apiDisabled(-25211) and no supported click mode; zero tests executed. AppleEvent cleanup timed out (-1712); each exact worktree-owned leftover app PID was verified, terminated, and confirmed gone. They were not repeated during review. Evidence:apps/storybook/artifacts/desktop/65fb216f-89ee-43db-86a6-333b3d91331e/run.json(Fabric) andcfab6e50-9b38-45d3-b114-05b3ea995037/run.json(Paper).Windows CI sufficient: yes, for F6's changed paths. Same-branch run 43156299266 passed every check on
58ec7ab4fb7ce6e449d0e351ecb02352bf88f319on November 12, 2026. Full job logs and downloaded terminalrun.jsonreports, not only green job conclusions, confirm:All three reports have zero failed, skipped, incomplete, retried, or flaky tests and zero groups not run. Unique passing navigation IDs match the full rendered index; there was no early stop. The quarantine is not counted as a pass.
The five checks are mandatory gates in all three executed native paths, rather than separately logged success messages:
storybook-control.cjs's strict shared v3 parser.D:workspace /C:private-store split exercise the transformer's private-buffer read/digest check and original-worker delegation, followed by successful runtime rendering.Full-log anchors (bundle, native readiness, all stories, authored tests, terminal totals): Windows 655, 669–670, 709, 1230, 2295; Win32 accessible 502, 508–510, 511, 1097, 1118; Win32 physical 499, 505–507, 508, 1809, 1845. Artifact IDs 13916946307 / 13917010025 / 13916318019 contain main smoke
run.jsonreports 414aa6f1-a539-4d67-9aa4-a92db05b58a4 / 00cae5a0-ef44-45cf-aaa9-68485ecf2403 / e5767c29-e4b1-4a9b-9685-8cdf8e0d3ee1, respectively. The F6 ledger records the artifact names and detailed gate/evidence mapping.Limits: collected channel stderr includes non-terminal
bridge-unavailablenavigation diagnostics on Windows and an authenticated-epochlease-invaliddiagnostic on Win32 physical. Buffered output does not establish their original timing. These results do not claim diagnostic-free operation or general bridge-recovery qualification. The local macOS Accessibility block and missing localpwshparser check remain as recorded above; no local smoke was repeated. This PR remains draft pending the documentation follow-up's CI and the coordinator's readiness decision.The documentation-only qualification follow-up
aadc2f359passed the exact ledger-format, root link-check, and repository-safeguard commands listed above (90 link tasks passed). Package/source/native suites were not rerun for this reporting-only change. Local evidence:apps/storybook/artifacts/f6/qualification-docs-{format,links,checks}.log./varand symlinked project paths failed with a generic storage error.C:private source relative to aD:workspace, producingD:\C:\....Pull request checklist
This PR has considered (when applicable):