Skip to content

Commit 64d4b18

Browse files
fogelekPatrycja Fogelman
andauthored
Fixed no onNavigate event not firing when clicked on a leaf (#34964)
Co-authored-by: Patrycja Fogelman <patrycja.fogelman@microsoft.com>
1 parent ec6a9e6 commit 64d4b18

2 files changed

Lines changed: 16 additions & 7 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Fixed no onNavigate event not firing when clicked on a leaf",
4+
"packageName": "@fluentui/react-tree",
5+
"email": "patrycja.fogelman@microsoft.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-components/react-tree/library/src/components/TreeItem/useTreeItem.tsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export function useTreeItem_unstable(props: TreeItemProps, ref: React.Ref<HTMLDi
122122
} else if (!isEventFromExpandIcon) {
123123
onClick?.(event);
124124
}
125-
if (event.isDefaultPrevented() || itemType === 'leaf') {
125+
if (event.isDefaultPrevented()) {
126126
return;
127127
}
128128

@@ -134,12 +134,14 @@ export function useTreeItem_unstable(props: TreeItemProps, ref: React.Ref<HTMLDi
134134
target: event.currentTarget,
135135
type: isEventFromExpandIcon ? treeDataTypes.ExpandIconClick : treeDataTypes.Click,
136136
} as const;
137-
props.onOpenChange?.(event, data);
138-
requestTreeResponse({
139-
...data,
140-
itemType,
141-
requestType: 'open',
142-
});
137+
if (itemType !== 'leaf') {
138+
props.onOpenChange?.(event, data);
139+
requestTreeResponse({
140+
...data,
141+
itemType,
142+
requestType: 'open',
143+
});
144+
}
143145
requestTreeResponse({
144146
...data,
145147
itemType,

0 commit comments

Comments
 (0)