Skip to content

Commit b64fd7d

Browse files
authored
fix(deprecated): keep deprecated packages on their named prerelease line (#36627)
1 parent 4832a42 commit b64fd7d

10 files changed

Lines changed: 58 additions & 11 deletions
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "fix: restore named beta prerelease line (9.0.x-0 was published by mistake)",
4+
"packageName": "@fluentui/react-alert",
5+
"email": "martinhochel@microsoft.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "chore: update pinned versions of deprecated packages moved back onto their beta line",
4+
"packageName": "@fluentui/react-components",
5+
"email": "martinhochel@microsoft.com",
6+
"dependentChangeType": "none"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "fix: restore named beta prerelease line (9.0.x-0 was published by mistake)",
4+
"packageName": "@fluentui/react-infobutton",
5+
"email": "martinhochel@microsoft.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "chore: disallow prepatch/preminor/premajor so dependent bumps stay on the alpha line",
4+
"packageName": "@fluentui/react-virtualizer",
5+
"email": "martinhochel@microsoft.com",
6+
"dependentChangeType": "none"
7+
}

packages/react-components/deprecated/react-alert/package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@fluentui/react-alert",
3-
"version": "9.0.2-0",
3+
"version": "9.0.2-beta.0",
44
"description": "An alert component to display brief messages",
55
"main": "lib-commonjs/index.cjs",
66
"module": "lib/index.js",
@@ -32,7 +32,10 @@
3232
"disallowedChangeTypes": [
3333
"major",
3434
"minor",
35-
"patch"
35+
"patch",
36+
"premajor",
37+
"preminor",
38+
"prepatch"
3639
]
3740
},
3841
"exports": {

packages/react-components/deprecated/react-infobutton/package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@fluentui/react-infobutton",
3-
"version": "9.0.1-0",
3+
"version": "9.0.1-beta.0",
44
"description": "React components for building web experiences",
55
"main": "lib-commonjs/index.cjs",
66
"module": "lib/index.js",
@@ -32,7 +32,10 @@
3232
"disallowedChangeTypes": [
3333
"major",
3434
"minor",
35-
"patch"
35+
"patch",
36+
"premajor",
37+
"preminor",
38+
"prepatch"
3639
]
3740
},
3841
"exports": {

packages/react-components/deprecated/react-virtualizer/package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@
2828
"disallowedChangeTypes": [
2929
"major",
3030
"minor",
31-
"patch"
31+
"patch",
32+
"premajor",
33+
"preminor",
34+
"prepatch"
3235
]
3336
},
3437
"exports": {

packages/react-components/react-components/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"license": "MIT",
1414
"dependencies": {
1515
"@fluentui/react-accordion": "^9.12.3",
16-
"@fluentui/react-alert": "9.0.2-0",
16+
"@fluentui/react-alert": "9.0.2-beta.0",
1717
"@fluentui/react-aria": "^9.17.14",
1818
"@fluentui/react-avatar": "^9.11.6",
1919
"@fluentui/react-badge": "^9.5.5",
@@ -29,7 +29,7 @@
2929
"@fluentui/react-drawer": "^9.13.3",
3030
"@fluentui/react-field": "^9.5.4",
3131
"@fluentui/react-image": "^9.4.4",
32-
"@fluentui/react-infobutton": "9.0.1-0",
32+
"@fluentui/react-infobutton": "9.0.1-beta.0",
3333
"@fluentui/react-infolabel": "^9.4.25",
3434
"@fluentui/react-input": "^9.8.6",
3535
"@fluentui/react-label": "^9.4.4",

scripts/executors/src/tag-react-components.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,16 @@ function tagPackage(name: string, version: string, npmToken: string): boolean {
2828
}
2929

3030
const prereleaseTag = prerelease[0];
31+
// npm rejects dist-tags that parse as a semver range, which is what an anonymous prerelease
32+
// like `9.0.1-0` yields. Nothing to tag, so warn instead of failing the release.
33+
if (typeof prereleaseTag === 'number' || semver.validRange(String(prereleaseTag)) !== null) {
34+
console.warn(
35+
`skipping dist-tag for ${name}@${version}: prerelease identifier "${prereleaseTag}" is not a usable tag name. ` +
36+
`Give this package a named prerelease version (e.g. "-beta.0") if it should be tagged.`,
37+
);
38+
return true;
39+
}
40+
3141
const command = `npm dist-tag add ${name}@${version} ${prereleaseTag} --registry https://registry.npmjs.org/ --//registry.npmjs.org/:_authToken=${npmToken}`;
3242
console.log(command);
3343
try {

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3354,7 +3354,7 @@ __metadata:
33543354
languageName: unknown
33553355
linkType: soft
33563356

3357-
"@fluentui/react-alert@npm:9.0.2-0, @fluentui/react-alert@workspace:packages/react-components/deprecated/react-alert":
3357+
"@fluentui/react-alert@npm:9.0.2-beta.0, @fluentui/react-alert@workspace:packages/react-components/deprecated/react-alert":
33583358
version: 0.0.0-use.local
33593359
resolution: "@fluentui/react-alert@workspace:packages/react-components/deprecated/react-alert"
33603360
dependencies:
@@ -3901,7 +3901,7 @@ __metadata:
39013901
resolution: "@fluentui/react-components@workspace:packages/react-components/react-components"
39023902
dependencies:
39033903
"@fluentui/react-accordion": "npm:^9.12.3"
3904-
"@fluentui/react-alert": "npm:9.0.2-0"
3904+
"@fluentui/react-alert": "npm:9.0.2-beta.0"
39053905
"@fluentui/react-aria": "npm:^9.17.14"
39063906
"@fluentui/react-avatar": "npm:^9.11.6"
39073907
"@fluentui/react-badge": "npm:^9.5.5"
@@ -3917,7 +3917,7 @@ __metadata:
39173917
"@fluentui/react-drawer": "npm:^9.13.3"
39183918
"@fluentui/react-field": "npm:^9.5.4"
39193919
"@fluentui/react-image": "npm:^9.4.4"
3920-
"@fluentui/react-infobutton": "npm:9.0.1-0"
3920+
"@fluentui/react-infobutton": "npm:9.0.1-beta.0"
39213921
"@fluentui/react-infolabel": "npm:^9.4.25"
39223922
"@fluentui/react-input": "npm:^9.8.6"
39233923
"@fluentui/react-label": "npm:^9.4.4"
@@ -4511,7 +4511,7 @@ __metadata:
45114511
languageName: unknown
45124512
linkType: soft
45134513

4514-
"@fluentui/react-infobutton@npm:9.0.1-0, @fluentui/react-infobutton@workspace:packages/react-components/deprecated/react-infobutton":
4514+
"@fluentui/react-infobutton@npm:9.0.1-beta.0, @fluentui/react-infobutton@workspace:packages/react-components/deprecated/react-infobutton":
45154515
version: 0.0.0-use.local
45164516
resolution: "@fluentui/react-infobutton@workspace:packages/react-components/deprecated/react-infobutton"
45174517
dependencies:

0 commit comments

Comments
 (0)