Skip to content

Commit 8252729

Browse files
algattikCopilot
andcommitted
feat(skills): adopt hve-core RPI skill workflow
- provision and verify the complete pinned RPI skill suite\n- retire persona agents and preserve repository-specific safeguards\n- separate runtime and derived-file pins 🚀 - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 08c2972 commit 8252729

15 files changed

Lines changed: 923 additions & 327 deletions

.cspell.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
"yolov"
7171
],
7272
"ignorePaths": [
73+
".agent/reviews/**",
7374
"**/.github/chatmodes/**",
7475
"**/node_modules/**",
7576
"**/vscode-extension/**",

.github/agents/physical-ai-rpi-worker.agent.md

Lines changed: 0 additions & 47 deletions
This file was deleted.

.github/agents/physical-ai-rpi.agent.md

Lines changed: 0 additions & 120 deletions
This file was deleted.

.github/copilot-instructions.md

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -330,17 +330,32 @@ Treat `.github/workflows/copilot-setup-steps.yml` and `.devcontainer/devcontaine
330330

331331
The weekly `copilot-setup-steps.yml` cron and `Test-BinaryFreshness.ps1` weekly run together surface upstream drift across both surfaces.
332332

333-
### Cloud-Agent RPI Wrapper
333+
### Cloud-Agent RPI Skills
334334

335-
The `Bootstrap hve-core RPI persona` step in `copilot-setup-steps.yml` runs **outside** the cloud-agent firewall and downloads the latest `microsoft/hve-core@main` `rpi-agent.agent.md` plus every `subagents/*.agent.md` into `.copilot-tracking/upstream/hve-core-rpi/`.
335+
The `Bootstrap hve-core RPI skills` step in `copilot-setup-steps.yml` runs **outside** the cloud-agent firewall and downloads the complete RPI skill suite from a pinned `microsoft/hve-core` commit into immediate subdirectories of `.github/skills/`.
336336

337-
The `Physical-AI RPI` umbrella (`.github/agents/physical-ai-rpi.agent.md`) and its hidden generic worker (`.github/agents/physical-ai-rpi-worker.agent.md`) read those files at session start. The worker resolves a `persona: <stem>` dispatch parameter to a workspace path under `.copilot-tracking/upstream/hve-core-rpi/subagents/`, so new upstream personas auto-onboard via the next bootstrap with no change in this repo.
337+
The generated `.github/skills/rpi-*/` directories are gitignored and excluded from repository Markdown linting. The standalone bootstrap script stages downloads before installation, accepts Markdown blobs only, verifies each pinned Git blob SHA, requires all eight skill entry points, rejects unexpected top-level content, and records the resolved commit, file paths, and blob SHAs in `.github/skills/.rpi-audit.json`. Bootstrap failure is fatal because no local fallback provides these workflows.
338338

339-
See [docs/reference/copilot-artifacts.md](../docs/reference/copilot-artifacts.md) for the full umbrella/worker rationale.
339+
The cloud agent discovers the `rpi-quick`, `rpi-research`, `rpi-plan`, `rpi-implement`, and `rpi-review` workflows directly from their `SKILL.md` files. The bootstrap also preserves `rpi-challenger`, `rpi-plan-critique`, `rpi-walkthrough`, and every bundled reference and template.
340+
341+
The current immutable commit predates a published hve-core release containing the skill-forward layout. Prefer a released commit on upgrades; when none exists, review the complete upstream commit and tree before changing `UPSTREAM_REF`.
342+
343+
Before starting RPI work, verify `.github/skills/.rpi-audit.json` exists and contains the expected pinned `resolved_sha`; otherwise stop with a bootstrap failure. Treat `.copilot-tracking/` files as session scratch because the directory is gitignored.
344+
345+
In cloud-agent PR work, persist each completed RPI phase as a PR comment and maintain an `RPI Artifact Index` in the PR description with the phase comment links and resolved upstream SHA. If PR write tools are unavailable, include the complete phase artifacts in the final response rather than claiming durable persistence.
346+
347+
When RPI work touches repository-specific surfaces, preserve these safeguards:
348+
349+
* `training/rl/**` and `training/rl/scripts/train.sh`: verify Isaac Sim ABI compatibility for numpy, torch, tensordict, ONNX Runtime GPU, SciPy, scikit-learn, PyArrow, OpenCV, and pynvml changes.
350+
* `evaluation/**/Dockerfile*` and `Dockerfile.lerobot-eval`: cross-check CUDA and cuDNN base-image changes against torch and ONNX Runtime GPU.
351+
* `infrastructure/terraform/**`: call out AzureRM provider major-version changes explicitly.
352+
* `data-management/viewer/**`: apply the FastAPI and React rules in `.github/instructions/dataviewer.instructions.md`.
353+
354+
See [docs/reference/copilot-artifacts.md](../docs/reference/copilot-artifacts.md) for the RPI skill inventory.
340355

341356
## hve-core Derived Files
342357

343-
Follow the baseline conventions in [`scripts/README.md`](../scripts/README.md). `scripts/security/Test-HveCoreFreshness.ps1` compares source-header entries with a resolved upstream `main` commit and release entries with the RPI `UPSTREAM_REF` and a resolved latest non-draft release commit.
358+
Follow the baseline conventions in [`scripts/README.md`](../scripts/README.md). `scripts/security/Test-HveCoreFreshness.ps1` compares source-header entries with a resolved upstream `main` commit and release entries with `HVE_CORE_DERIVED_FILES_REF` and a resolved latest non-draft release commit.
344359

345360
## Git Workflow
346361

.github/instructions/dataviewer.instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ CodeQL workaround for logging:
5454

5555
This can be done with `Depends()` on parameters.
5656

57-
## RPI Agent High Priority Instructions
57+
## RPI Skill High Priority Instructions
5858

59-
These instructions take priority over instructions from RPI Agent (rpi-agent.agent.md):
59+
These instructions take priority over the runtime-provisioned `rpi-*` skills:
6060

6161
* Use the browser tools during research, planning, implementation, review, and discovery as they will provide details about the running application while working and planning.
6262
* Always create or update test(s) to be failing before any implementation work.

.github/instructions/shell-scripts.instructions.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ info "Operation complete"
100100

101101
<!-- <important-conventions> -->
102102

103+
Standalone trust-bootstrap scripts under `scripts/ci/` may omit `common.sh`,
104+
argument parsing, `--config-preview`, and deployment summaries when sourcing
105+
repository helpers would widen the bootstrap trust boundary.
106+
103107
**Arguments:**
104108

105109
- Short: `-h`, `-t` | Long: `--help`, `--tf-dir`

0 commit comments

Comments
 (0)