Skip to content

Commit 9d841d5

Browse files
WilliamBerryiiiBill Berry
andauthored
fix(ci): pin pydantic to ==2.12.5 across all references (#230)
## Description Pinned the `pydantic` dependency to exact version **==2.12.5** in all three locations where it was referenced. The CI workflow previously used a range constraint (`>=2.10.0,<3.0.0`), *pyproject.toml* had no version constraint, and *config/README.md* referenced an unpinned install. This consolidation ensures consistent behavior across local development, CI, and manual regeneration workflows. Closes #147 ## Type of Change - [x] 🐛 Bug fix (non-breaking change fixing an issue) - [ ] ✨ New feature (non-breaking change adding functionality) - [ ] 💥 Breaking change (fix or feature causing existing functionality to change) - [x] 📚 Documentation update - [ ] 🏗️ Infrastructure change (Terraform/IaC) - [ ] ♻️ Refactoring (no functional changes) ## Component(s) Affected - [ ] `deploy/000-prerequisites` - Azure subscription setup - [ ] `deploy/001-iac` - Terraform infrastructure - [ ] `deploy/002-setup` - OSMO control plane / Helm - [ ] `deploy/004-workflow` - Training workflows - [ ] `src/training` - Python training scripts - [ ] `docs/` - Documentation ## Testing Performed - [ ] Terraform `plan` reviewed (no unexpected changes) - [ ] Terraform `apply` tested in dev environment - [ ] Training scripts tested locally with Isaac Sim - [ ] OSMO workflow submitted successfully - [ ] Smoke tests passed (`smoke_test_azure.py`) ## Documentation Impact - [ ] No documentation changes needed - [x] Documentation updated in this PR - [ ] Documentation issue filed ## Bug Fix Checklist - [x] Linked to issue being fixed - [ ] Regression test included, OR - [x] Justification for no regression test: The CI workflow *validate-config-schema* already validates schema generation with the installed pydantic version. Changing the pin does not alter runtime behavior — only the resolved version. ## Checklist - [x] My code follows the [project conventions](copilot-instructions.md) - [x] Commit messages follow [conventional commit format](instructions/commit-message.instructions.md) - [x] I have performed a self-review - [x] Documentation impact assessed above - [x] No new linting warnings introduced --------- Co-authored-by: Bill Berry <wbery@microsoft.com>
1 parent 34d5575 commit 9d841d5

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/validate-config-schema.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
uses: astral-sh/setup-uv@6ee6290f1cbc4156c0bdd66691b2c144ef8df19a # v7.4.0
3636

3737
- name: Install dependencies
38-
run: uv pip install --system "pydantic>=2.10.0,<3.0.0"
38+
run: uv pip install --system "pydantic==2.12.5"
3939

4040
- name: Regenerate schema
4141
run: python data-pipeline/capture/config/generate_config_schema.py
@@ -49,7 +49,7 @@ jobs:
4949
echo "The JSON Schema file does not match the current pydantic models."
5050
echo "If the models have changed intentionally, regenerate the schema by running the following command locally:"
5151
echo ""
52-
echo " uv pip install pydantic && python data-pipeline/capture/config/generate_config_schema.py"
52+
echo " uv pip install 'pydantic==2.12.5' && python data-pipeline/capture/config/generate_config_schema.py"
5353
echo ""
5454
echo "Then commit the updated schema file."
5555
echo ""

data-pipeline/capture/config/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ Regenerate the schema whenever you modify:
215215

216216
```bash
217217
# Run the schema generation script
218-
pip install pydantic && PYTHONPATH=. python config/generate_config_schema.py
218+
pip install 'pydantic==2.12.5' && PYTHONPATH=. python config/generate_config_schema.py
219219
220220
# Verify the updated schema
221221
git diff config/recording_config.schema.json
@@ -236,5 +236,5 @@ The CI/CD pipeline validates that the schema is up-to-date with the pydantic mod
236236

237237
## 🔗 Related Documentation
238238

239-
* [LeRobot Integration](../docs/lerobot-inference.md) - Dataset structure and feature mapping
240-
* [AzureML Validation Job Debugging](../docs/azureml-validation-job-debugging.md) - Training pipeline integration
239+
* [LeRobot Integration](../docs/inference/lerobot-inference.md) - Dataset structure and feature mapping
240+
* [AzureML Validation Job Debugging](../docs/operations/azureml-validation-job-debugging.md) - Training pipeline integration

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dev = [
1818
"pytest",
1919
"pytest-mock",
2020
"pytest-cov",
21-
"pydantic",
21+
"pydantic==2.12.5",
2222
"ipykernel",
2323
"ipywidgets",
2424
"tqdm",

0 commit comments

Comments
 (0)