Commit e6fa6ea
authored
fix(workflows): use bash shell for uv.lock regeneration and add SARIF to dictionary (#225)
## Description
Two targeted CI fixes that unblock the release-please v0.5.0 PR. The
main CI workflow's **Regenerate uv.lock** step used bash `if/then/fi`
syntax but ran under the workflow-level `shell: pwsh` default, producing
a `ParserError` on every push to `main`. Additionally, the cspell spell
check flagged **SARIF** as an unknown word in the auto-generated
*CHANGELOG.md*, blocking PR validation on the release-please branch.
- Added explicit `shell: bash` to the **Regenerate uv.lock** step in
*.github/workflows/main.yml*, overriding the `pwsh` default for that
step only
- All other `run:` blocks in the workflow use PowerShell-compatible
syntax and remain unaffected
- Added **SARIF** to *.cspell/industry-acronyms.txt* in alphabetical
position between `Rego` and `SBOM`
## Type of Change
- [x] 🐛 Bug fix (non-breaking change fixing an issue)
- [ ] ✨ New feature (non-breaking change adding functionality)
- [ ] 💥 Breaking change (fix or feature causing existing functionality
to change)
- [ ] 📚 Documentation update
- [ ] 🏗️ Infrastructure change (Terraform/IaC)
- [ ] ♻️ Refactoring (no functional changes)
## Component(s) Affected
- [ ] `deploy/000-prerequisites` - Azure subscription setup
- [ ] `deploy/001-iac` - Terraform infrastructure
- [ ] `deploy/002-setup` - OSMO control plane / Helm
- [ ] `deploy/004-workflow` - Training workflows
- [ ] `src/training` - Python training scripts
- [ ] `docs/` - Documentation
## Testing Performed
- [ ] Terraform `plan` reviewed (no unexpected changes)
- [ ] Terraform `apply` tested in dev environment
- [ ] Training scripts tested locally with Isaac Sim
- [ ] OSMO workflow submitted successfully
- [ ] Smoke tests passed (`smoke_test_azure.py`)
## Documentation Impact
- [x] No documentation changes needed
- [ ] Documentation updated in this PR
- [ ] Documentation issue filed
## Bug Fix Checklist
*Complete this section for bug fix PRs. Skip for other contribution
types.*
- [ ] Linked to issue being fixed
- [ ] Regression test included, OR
- [ ] Justification for no regression test: CI workflow fix verified by
existing CI pipeline execution; cspell dictionary addition verified by
`npm run spell-check`.
## Checklist
- [x] My code follows the [project conventions](copilot-instructions.md)
- [x] Commit messages follow [conventional commit
format](instructions/commit-message.instructions.md)
- [x] I have performed a self-review
- [x] Documentation impact assessed above
- [x] No new linting warnings introduced
## Notes
> These two CI failures were blocking the release-please PR #173 for
v0.5.0. Once merged, the release-please PR validation should pass.
## Related Issues
None1 parent cfdf47a commit e6fa6ea
2 files changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| 191 | + | |
191 | 192 | | |
192 | 193 | | |
193 | 194 | | |
| |||
0 commit comments