Skip to content

devops(ci): run Windows tests at normal I/O priority #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into from
Oct 28, 2026
+68 −8
Merged

devops(ci): run Windows tests at normal I/O priority #3296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,21 +127,31 @@ jobs:
id: install
run: python -m playwright install --with-deps ${{ matrix.browser }}
- name: Common Tests
run: pytest tests/common --browser=${{ matrix.browser }}
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/common --browser=${{ matrix.browser }}
- name: Test Reference count
run: pytest tests/test_reference_count_async.py --browser=${{ matrix.browser }}
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/test_reference_count_async.py --browser=${{ matrix.browser }}
- name: Test Wheel Installation
run: pytest tests/test_installation.py --browser=${{ matrix.browser }}
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/test_installation.py --browser=${{ matrix.browser }}
- name: Test Sync API
if: runner.os != 'Linux'
run: pytest tests/sync --browser=${{ matrix.browser }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/sync --browser=${{ matrix.browser }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
- name: Test Sync API
if: runner.os == 'Linux'
run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" pytest tests/sync --browser=${{ matrix.browser }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
- name: Test Async API
# Also after a failed sync step: the two suites report on their own.
if: ${{ !cancelled() && steps.install.outcome == 'success' && runner.os != 'Linux' }}
run: pytest tests/async --browser=${{ matrix.browser }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/async --browser=${{ matrix.browser }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
- name: Test Async API
if: ${{ !cancelled() && steps.install.outcome == 'success' && runner.os == 'Linux' }}
run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" pytest tests/async --browser=${{ matrix.browser }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
Expand Down Expand Up @@ -187,17 +197,23 @@ jobs:
id: install
run: python -m playwright install ${{ matrix.browser-channel }} --with-deps
- name: Common Tests
run: pytest tests/common --browser=chromium --browser-channel=${{ matrix.browser-channel }}
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/common --browser=chromium --browser-channel=${{ matrix.browser-channel }}
- name: Test Sync API
if: runner.os != 'Linux'
run: pytest tests/sync --browser=chromium --browser-channel=${{ matrix.browser-channel }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/sync --browser=chromium --browser-channel=${{ matrix.browser-channel }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
- name: Test Sync API
if: runner.os == 'Linux'
run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" pytest tests/sync --browser=chromium --browser-channel=${{ matrix.browser-channel }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
- name: Test Async API
# Also after a failed sync step: the two suites report on their own.
if: ${{ !cancelled() && steps.install.outcome == 'success' && runner.os != 'Linux' }}
run: pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
run: |
${{ runner.os == 'Windows' && '. ./scripts/windows-normal-io.ps1' || '' }}
pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
- name: Test Async API
if: ${{ !cancelled() && steps.install.outcome == 'success' && runner.os == 'Linux' }}
run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} -n ${{ env.WORKERS }} -p pytest_dot_reporter -rfE --color=yes
Expand Down
44 changes: 44 additions & 0 deletions scripts/windows-normal-io.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Dot-source at the start of a Windows test step: the self-hosted runner starts steps at
# I/O priority Low, which the driver and the browsers inherit, and Firefox storage flushes
# then stall until tests time out. See https://github.com/microsoft/playwright/issues/43704.

$ErrorActionPreference = 'Stop'

Add-Type -TypeDefinition @'
using System;
using System.Runtime.InteropServices;

public static class TestProcessIOPriority {
[DllImport("ntdll.dll")]
public static extern int NtSetInformationProcess(
IntPtr process, int informationClass, ref int information, int size);

[DllImport("ntdll.dll")]
public static extern int NtQueryInformationProcess(
IntPtr process, int informationClass, out int information, int size, out int length);
}
'@

$priority = 0
$length = 0
$status = [TestProcessIOPriority]::NtQueryInformationProcess(
[IntPtr](-1), 33, [ref]$priority, 4, [ref]$length)
if ($status -ne 0) {
throw ('Reading I/O priority failed: NTSTATUS 0x{0:X8}' -f $status)
}
$inheritedPriority = $priority
$priority = 2
$status = [TestProcessIOPriority]::NtSetInformationProcess(
[IntPtr](-1), 33, [ref]$priority, 4)
if ($status -ne 0) {
throw ('Setting normal I/O priority failed: NTSTATUS 0x{0:X8}' -f $status)
}
$status = [TestProcessIOPriority]::NtQueryInformationProcess(
[IntPtr](-1), 33, [ref]$priority, 4, [ref]$length)
if ($status -ne 0) {
throw ('Reading I/O priority failed: NTSTATUS 0x{0:X8}' -f $status)
}
if ($priority -ne 2) {
throw "Expected normal I/O priority (2), got $priority"
}
Write-Host "Test launcher I/O priority: $inheritedPriority -> $priority (Normal)"
Loading