Skip to content

fix(macos): keep a press on a view from reaching a text field beneath it - #3143

Open
Bron Davies (brondavies) wants to merge 2 commits into
microsoft:mainfrom
brondavies:fix/view-keeps-mouse-down
Open

Bron Davies (brondavies) wants to merge 2 commits into
microsoft:mainfrom
brondavies:fix/view-keeps-mouse-down

Conversation

@brondavies

@brondavies Bron Davies (brondavies) commented Oct 23, 2026 •

Copy link
Copy Markdown

Summary:

On macOS, a Pressable drawn over a TextInput that is being edited never fires onPress. The surface's touch handler gets the press, but RCTViewComponentView doesn't implement mouseDown:, so NSView's default passes it on (through -_nextResponderForEvent:) to the text field beneath the point. The field's tracking loop then consumes the mouseUp, and the press never ends.

This accepts mouseDown: in RCTViewComponentView only when the view can't move the window (mouseDownCanMoveWindow is NO), which Pressable sets on its view. Every other view keeps NSView's default, so window dragging and native views hosting React Native are unaffected. It's the same pattern as rightMouseDown: and otherMouseDown:, which are accepted only when the view has an onAuxClick handler.

Test Plan:

RNTester-macOS (Debug, arm64, Xcode 27.1, macOS 26.6.2), built from this branch. The Playground has three rows, each a TextInput with an absolutely positioned button over its right end: a Pressable, a TouchableOpacity and a plain View (onTouchEnd). Real clicks (HID events), counting presses:

Click on the button Pressable TouchableOpacity plain View
Field beneath not focused fires fires fires
Field beneath being edited (clicked into first) fires (3 of 3) doesn't fire (0 of 3); the click goes to the field doesn't fire; the click goes to the field

TouchableOpacity and the plain View keep mouseDownCanMoveWindow YES, so they take the same path as main; that's how a Pressable behaved before this change.

With mouseDownCanMoveWindow={false} passed from TouchableOpacity (a local edit, not in this PR), it fires as well while the field is being edited, and the plain View still behaves as on main.

@brondavies
Bron Davies (brondavies) requested a review from a team as a code owner October 23, 2026 18:33
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Thiago Vinhas (tvinhas) added a commit to tvinhas/react-native-macos that referenced this pull request Oct 28, 2026
Upstream v0.88.1 (30 commits, replayed onto the local v0.88.0 without the
agent files). Conflicts: fork identities and the vlists '*' peer kept;
Hermes 260318099.0.5; RCTStatusBarAppearance, the modal's status bar
capture and RCTRootViewController are iOS-only (macOS has no status bar,
visionOS lacks setNeedsStatusBarAppearanceUpdate); the SwiftUI filter
container sets safeAreaRegions through RCTPlatformHostingController;
SwiftPM autolinking keeps the per-platform UIKit/AppKit linker settings;
RNTester Podfile.lock regenerated with pod install.

Also from microsoft/react-native-macos (open PRs, macOS-only): secure
TextInput focus crash (microsoft#3141), TextInput color for bullets and plain text
(microsoft#3144), TextInput text stays put when resized while focused (microsoft#3150),
ScrollView scrolls over a multiline TextInput (microsoft#3146), inverted lists on
the new architecture (microsoft#3148), press over a TextInput (microsoft#3143), Dimensions
follow window resizes (microsoft#3142, plus removing its observer on invalidate),
RCTView shadow color retained (microsoft#3129), UIImage encoders extern "C"
(microsoft#3140), layout direction constants (microsoft#3131), and codegen skipping
unlinked third-party components (microsoft#3128, upstream react#59067).

.yarnrc.yml preapproves hermes-compiler@260318099.0.5 past the 7-day age
gate.
Comment on lines +2326 to +2333
- (void)mouseDown:(NSEvent *)event
{
// Accept mouseDown: the surface's touch handler, a gesture recognizer, has already taken the
// press. NSView's default passes it on to an overlapping sibling view beneath the point, and a
// text field there starts a tracking loop that consumes the mouseUp, so a button drawn over a
// TextInput would never be pressed.
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment seems a bit too driven by the context window, and I'm worried about the implications of overriding this for other scenarios where we don't want to accept the event. Copilot could you look into both making a newer comment and reviewing whether this is the right fix?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Accepting it on every view was too broad, and the comment too long. Narrowed in 3302f5f:

- (void)mouseDown:(NSEvent *)event
{
  // Accept mouseDown on views that can't move the window, such as Pressable, so it isn't passed on
  // to a text field beneath, whose tracking loop would consume the mouseUp the press needs.
  if (self.mouseDownCanMoveWindow) {
    [super mouseDown:event];
  }
}
  • Why that flag: Pressable sets mouseDownCanMoveWindow: false on its view. A view that says a press there can't move the window is claiming the press, as AppKit's own controls do. That prop also keeps the view from being flattened.
  • Every other view keeps NSView's default, so window dragging (isMovableByWindowBackground, title-bar areas) and native containers hosting React Native, such as table view cells, see no change.
  • Same pattern as rightMouseDown: and otherMouseDown:, which are accepted only when the view has an onAuxClick handler.
  • Not covered: TouchableOpacity and TouchableHighlight don't set mouseDownCanMoveWindow. I can pass false from them as Pressable does, here or in a follow-up, if you'd like.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in RNTester-macOS, built from this branch, with real clicks on a button over a TextInput that is being edited:

  • Pressable fires every time.
  • TouchableOpacity and a plain View don't; the click goes to the field. Both keep mouseDownCanMoveWindow YES, so that's main's behaviour.
  • With mouseDownCanMoveWindow={false} passed from TouchableOpacity (a local edit), it fires too, and the plain View is unchanged.

Details are in the description. Happy to add the TouchableOpacity/TouchableHighlight part here if you want it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants