Repository navigation
fix(macos): keep a press on a view from reaching a text field beneath it - #3143
Open
Bron Davies (brondavies) wants to merge 2 commits into
Open
Bron Davies (brondavies) wants to merge 2 commits into
Bron Davies (brondavies) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Thiago Vinhas (tvinhas)
added a commit
to tvinhas/react-native-macos
that referenced
this pull request
Oct 28, 2026
Upstream v0.88.1 (30 commits, replayed onto the local v0.88.0 without the agent files). Conflicts: fork identities and the vlists '*' peer kept; Hermes 260318099.0.5; RCTStatusBarAppearance, the modal's status bar capture and RCTRootViewController are iOS-only (macOS has no status bar, visionOS lacks setNeedsStatusBarAppearanceUpdate); the SwiftUI filter container sets safeAreaRegions through RCTPlatformHostingController; SwiftPM autolinking keeps the per-platform UIKit/AppKit linker settings; RNTester Podfile.lock regenerated with pod install. Also from microsoft/react-native-macos (open PRs, macOS-only): secure TextInput focus crash (microsoft#3141), TextInput color for bullets and plain text (microsoft#3144), TextInput text stays put when resized while focused (microsoft#3150), ScrollView scrolls over a multiline TextInput (microsoft#3146), inverted lists on the new architecture (microsoft#3148), press over a TextInput (microsoft#3143), Dimensions follow window resizes (microsoft#3142, plus removing its observer on invalidate), RCTView shadow color retained (microsoft#3129), UIImage encoders extern "C" (microsoft#3140), layout direction constants (microsoft#3131), and codegen skipping unlinked third-party components (microsoft#3128, upstream react#59067). .yarnrc.yml preapproves hermes-compiler@260318099.0.5 past the 7-day age gate.
Comment on lines
+2326
to
+2333
| - (void)mouseDown:(NSEvent *)event | ||
| { | ||
| // Accept mouseDown: the surface's touch handler, a gesture recognizer, has already taken the | ||
| // press. NSView's default passes it on to an overlapping sibling view beneath the point, and a | ||
| // text field there starts a tracking loop that consumes the mouseUp, so a button drawn over a | ||
| // TextInput would never be pressed. | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Comment seems a bit too driven by the context window, and I'm worried about the implications of overriding this for other scenarios where we don't want to accept the event. Copilot could you look into both making a newer comment and reviewing whether this is the right fix?
There was a problem hiding this comment.
Fair point. Accepting it on every view was too broad, and the comment too long. Narrowed in 3302f5f:
- (void)mouseDown:(NSEvent *)event
{
// Accept mouseDown on views that can't move the window, such as Pressable, so it isn't passed on
// to a text field beneath, whose tracking loop would consume the mouseUp the press needs.
if (self.mouseDownCanMoveWindow) {
[super mouseDown:event];
}
}- Why that flag:
PressablesetsmouseDownCanMoveWindow: falseon its view. A view that says a press there can't move the window is claiming the press, as AppKit's own controls do. That prop also keeps the view from being flattened. - Every other view keeps NSView's default, so window dragging (
isMovableByWindowBackground, title-bar areas) and native containers hosting React Native, such as table view cells, see no change. - Same pattern as
rightMouseDown:andotherMouseDown:, which are accepted only when the view has anonAuxClickhandler. - Not covered:
TouchableOpacityandTouchableHighlightdon't setmouseDownCanMoveWindow. I can passfalsefrom them asPressabledoes, here or in a follow-up, if you'd like.
There was a problem hiding this comment.
Tested in RNTester-macOS, built from this branch, with real clicks on a button over a TextInput that is being edited:
Pressablefires every time.TouchableOpacityand a plainViewdon't; the click goes to the field. Both keepmouseDownCanMoveWindowYES, so that'smain's behaviour.- With
mouseDownCanMoveWindow={false}passed fromTouchableOpacity(a local edit), it fires too, and the plainViewis unchanged.
Details are in the description. Happy to add the TouchableOpacity/TouchableHighlight part here if you want it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On macOS, a
Pressabledrawn over aTextInputthat is being edited never firesonPress. The surface's touch handler gets the press, butRCTViewComponentViewdoesn't implementmouseDown:, soNSView's default passes it on (through-_nextResponderForEvent:) to the text field beneath the point. The field's tracking loop then consumes themouseUp, and the press never ends.This accepts
mouseDown:inRCTViewComponentViewonly when the view can't move the window (mouseDownCanMoveWindowis NO), whichPressablesets on its view. Every other view keepsNSView's default, so window dragging and native views hosting React Native are unaffected. It's the same pattern asrightMouseDown:andotherMouseDown:, which are accepted only when the view has anonAuxClickhandler.Test Plan:
RNTester-macOS (Debug, arm64, Xcode 27.1, macOS 26.6.2), built from this branch. The Playground has three rows, each a
TextInputwith an absolutely positioned button over its right end: aPressable, aTouchableOpacityand a plainView(onTouchEnd). Real clicks (HID events), counting presses:PressableTouchableOpacityViewTouchableOpacityand the plainViewkeepmouseDownCanMoveWindowYES, so they take the same path asmain; that's how aPressablebehaved before this change.With
mouseDownCanMoveWindow={false}passed fromTouchableOpacity(a local edit, not in this PR), it fires as well while the field is being edited, and the plainViewstill behaves as onmain.