Repository navigation
fix(0.83, tests): restore macOS native test-host compilation - #3179
Open
Jason Morse (JasonVMo) wants to merge 1 commit into
Open
Jason Morse (JasonVMo) wants to merge 1 commit into
Jason Morse (JasonVMo) wants to merge 1 commit into
Conversation
Adapt the image portability and gzip C-linkage fixes from #3095 (742d47b and 60f09c4). Keep sanitizer policy unchanged: ASan and TSan both execute with the current toolchain. This separate prerequisite makes the renderer resize regression's existing native host buildable. Co-authored-by: Ty Rauber <tyrauber@mac.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33ea5c72-8bbd-448d-aa21-c9b99dd03c96
This was referenced Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Backport the source-compatible parts of #3095, by Ty Rauber
(
742d47b5728aand60f09c46099b), to 0.83-stable:UIImagereferences in shared image tests with theexisting
RCTPlatformImagealias.RCT_EXTERN, restoring C linkage for Objective-C test callers.react-native-macospatch Changeset.This separate prerequisite makes #3178's bounded native resize regression
runnable in the existing macOS XCTest host. It does not include that
renderer fix, its fixture, or FURN/CI-workflow changes. Main already has
#3095, so no duplicate main PR is opened.
The old Xcode 26.0.1 sanitizer-disable workaround from #3095 is deliberately
not copied. The current toolchain executes the native-props fixture under
ASan and TSan; this PR changes no sanitizer/test-plan policy.
Test Plan:
The baseline macOS test target fails compiling its unchanged image tests.
With these exact four source-file changes applied to the isolated #3178
qualification worktree, the real XCTest target builds, links, and executes
the committed resize fixture: 1 test passed, 0 failures.
Exact native commands, with
NATIVE_PROPS_EVIDENCEdenoting the localqualification artifact directory:
The qualification worktree first regenerated Pods and clean-built all affected
native libraries. Its local-only profile selects a single ordinary run
without the pre-existing retry default. No assertions, tests, or animations
were disabled, and these profile overrides are not committed. Separate
sanitizer evidence belongs to the renderer PR, not this ordinary run.
Scoped source checks from the prerequisite worktree:
The Changeset's Ruby YAML check passed with exactly
{"react-native-macos"=>"patch"}. Not run: the entire native test suite,legacy-bridge runtime tests on New-Architecture-only 0.83, iOS runtime,
repository-wide JS/Flow/lint suites, or publication. No PR is merged.